Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing OutputModules only get products they consume #13467

Merged

Conversation

Dr15Jones
Copy link
Contributor

ProvenanceCheckerOutputModule and GetProductCheckerOutputModule now only get the data products specified in their configuration rather than everything in the Principal.
This is a step towards removing the Principal::getForOutput option which avoids getting the product. That option would cause problems for multiple threads used for one event.

ProvenanceCheckerOutputModule and GetProductCheckerOutputModule now only get the data products specified in their configuration rather than everything in the Principal.
This is a step towards removing the Principal::getForOutput option which avoids getting the product. That option would cause problems for multiple threads used for one event.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X.

It involves the following packages:

FWCore/Modules

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

@wmtan here is the change I said I was going to make today

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11507/console

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1

Tested at: 5ab648f
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13467/11507/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1d39440
d7e1889
efce6c5
e5e2174
70013d3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13467/11507/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13467/11507/git-merge-result

@Dr15Jones
Copy link
Contributor Author

The test failure is not from this pull request

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor Author

This failure is not from this pull request and comes from the IB.

davidlange6 added a commit that referenced this pull request Feb 26, 2016
Testing OutputModules only get products they consume
@davidlange6 davidlange6 merged commit c615ffb into cms-sw:CMSSW_8_1_X Feb 26, 2016
@Dr15Jones Dr15Jones deleted the outputModulesUseKeptProducts branch March 28, 2016 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants