[RecoTauTag] migration to stage-2 L1 #13480
Conversation
|
A new Pull Request was created by @rmanzoni (Riccardo Manzoni) for CMSSW_8_0_X. It involves the following packages: RecoTauTag/HLTProducers @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| l1t::JetVectorRef jetCandRefVec; | ||
| l1t::JetVectorRef objL1CandRefVec; | ||
| l1t::JetRef tauCandRef; | ||
|
|
There was a problem hiding this comment.
Taus at stage-2 have their own class type, the jet class is not reused (as it was in stage-1)
There was a problem hiding this comment.
this module is not used anymore (since the advent of stage-1 I think) and I couldn't find it in the latest menus.
I would be for getting rid of it, if you agree.
Otherwise I'll fix it.
There was a problem hiding this comment.
Removal is fine with me!
There was a problem hiding this comment.
There was a problem hiding this comment.
ok, then I leave the old L1HLTJetsMatching (w/o 'T') but will not add it's stage-2 sibling L1THLTJetsMatching (w/ 'T')
|
Why do you actually need to change L1HLTTauMatching to L1THLTTauMatching? |
|
perhaps the change is not fundamental, in the sense that this module is not reading any collection spat out by the L1, but internally it uses types which live under l1extra namespace, e.g. |
|
right, ok, so we need the L1THLTTauMatching |
|
Pull request #13480 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please check and sign again. |
| aDesc.addUntracked<int> ("verbose" , 0 )->setComment("Verbosity level; 0=silent" ); | ||
| aDesc.addUntracked<int> ("BX" , 0 )->setComment("Set bunch crossing; 0 = in time, -1 = previous, 1 = following"); | ||
|
|
||
| desc.add ("caloTowerMakerHLT", aDesc); |
There was a problem hiding this comment.
The string should be the class name, at most starting with a lower-case 'c'.
Also to be different from the one in the old module!
There was a problem hiding this comment.
you mean something like:
desc.add ("caloTowerFromL1TMakerHLT", aDesc);
|
Pull request #13480 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please check and sign again. |
|
|
||
| CaloTowerFromL1TCreatorForTauHLT::CaloTowerFromL1TCreatorForTauHLT( const ParameterSet & p ) | ||
| : | ||
| mBX (p.getUntrackedParameter<int> ("BX" , 0) ), |
There was a problem hiding this comment.
This changes physics so must be tracked.
|
Pull request #13480 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please check and sign again. |
|
please test |
|
Pull request #13480 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
hlt-approved
fully-signed
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
…gration [RecoTauTag] migration to stage-2 L1
Tau specific modules that were using old legacy/stage-1
l1extracollections have been cloned and migrated to new stage-2l1tcollections [*]:L1HLTJetsMatching→L1THLTJetsMatching(this is was used with the Run1 system but not with stage-1, shall we get rid of it?)L1HLTTauMatching→L1THLTTauMatchingCaloTowerCreatorForTauHLT→CaloTowerFromL1TCreatorForTauHLT[*]
we followed the instructions in
https://docs.google.com/document/d/1GnnWAaP1C-dbMreC72XCJ5ToQZ55Vfy-O7X_ON5GYjs/edit#
and
https://hypernews.cern.ch/HyperNews/CMS/get/hlt/4171/1.html