add missing initialization in CaloCluster (same as #13506 )

[slava77]

add missing correctedEnergyUncertainty_ initialization in a few constructors

Some of the CaloCluster (or classes deriving from it) collections do not use the correctedEnergy* data members, in some cases the correctedEnergyUncertainty_ was never initialized. This generated occasional random numbers in the saved products and can also trigger fake differences in event size comparisons.

after the fix all values are now appropriately set to 1 (the plot isn't showing it directly, but it shows that there is a range of values in the old/baseline version)

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11588/console

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/CaloRecHit

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[cmsbuild]

-1

Tested at: e9a80c0
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13507/11588/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13507/11588/summary.html

[slava77]

+1

for #13507 e9a80c0

• the same topic branch as add missing initialization in CaloCluster #13506
• jenkins tests pass (ignoring the unit tests that fail also in IB); comparisons with baseline show no differences (the correctedEnergy* variables are not in the monitored list)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1