Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update L1T GT/Calo/GMT unpackers to have non-null product instances #13547

Merged

Conversation

mulhearn
Copy link
Contributor

@mulhearn mulhearn commented Mar 2, 2016

The unpacker code for L1T GT/Calo/GMT unpackers are updated to set the product instance to the object type.

This allows downstream HLT code to use edm::View in order to access the four-vectors of L1T objects.

The L1T downstream code required updates to adapt to this change, which has been completed, for all but some test code in L1Trigger/L1TGlobal which can be adapted separately.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

A new Pull Request was created by @mulhearn for CMSSW_8_0_X.

It involves the following packages:

DQM/L1TMonitor
EventFilter/L1TRawToDigi
HLTrigger/HLTfilters
L1Trigger/Configuration
L1Trigger/HardwareValidation
L1Trigger/L1TCalorimeter
L1Trigger/L1TCommon
L1Trigger/L1TGlobal
L1Trigger/L1TNtuples

@perrotta, @cmsbuild, @Martin-Grunewald, @deguio, @fwyzard, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn
Copy link
Contributor Author

mulhearn commented Mar 2, 2016

I'm not signing this one until I better understand where it should go (i.e. into MWGR#3).

@mulhearn
Copy link
Contributor Author

mulhearn commented Mar 2, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11666/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

@Martin-Grunewald
Copy link
Contributor

+1

@mulhearn
Copy link
Contributor Author

mulhearn commented Mar 3, 2016

+1

davidlange6 added a commit that referenced this pull request Mar 3, 2016
…date

Update L1T GT/Calo/GMT unpackers to have non-null product instances
@davidlange6 davidlange6 merged commit bdd4dc4 into cms-sw:CMSSW_8_0_X Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants