New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EG L1S1 to L1S2 migration #13558
EG L1S1 to L1S2 migration #13558
Conversation
A new Pull Request was created by @Sam-Harper for CMSSW_8_0_X. It involves the following packages: HLTrigger/Egamma @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
@gpasztor
This is the E/gamma migration from stage-1 to stage-2. A lot of the work was also done by Gabriella Pasztor, her work was the base I started from. Because my gitfoo is not strong, I ended up having to lose her commits (it was easier just to copy over the 2 new files and the 2 modified files.
Modules accessing L1 actually in the menu:
HLTEgammaL1MatchFilterRegional:
HLTEcalRecHitInAllL1RegionsProducer
EgammaHLTCaloTowerProducer
Modules not in menu which use L1 info:
HLTEgammaL1MatchFilterPairs:
HLTRechitInRegionsProducer:
Configuration changes needed to work the new menu:
Future updates:
We tried to have minimal changes as requested. But we would like to rename the input parameters of HLTEgammaL1MatchFilterRegional to take into account that the L1EGs are not seperated in non-isolated, isolated. We also have to study the new matching requirements at L1. Right now its probably overly large.