Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hcal tb2006 update #13559

Merged
merged 4 commits into from Mar 3, 2016
Merged

Hcal tb2006 update #13559

merged 4 commits into from Mar 3, 2016

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Mar 2, 2016

Analysis of Hcal TB is updated: more configuration parameters; selection of 7x7 for Ecal and and 3x3 for Hcal; noise added.
Cleanup Ecal TB sub-package: use consumes and getByToken; producers moved to plugin sub-directory.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_8_1_X.

It involves the following packages:

SimG4CMS/EcalTestBeam
SimG4CMS/HcalTestBeam

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @argiro this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@civanch
Copy link
Contributor Author

civanch commented Mar 3, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11679/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

@civanch
Copy link
Contributor Author

civanch commented Mar 3, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 3, 2016
@cmsbuild cmsbuild merged commit db25ba1 into cms-sw:CMSSW_8_1_X Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants