migration to stage-2 L1 for muon modules

[sarafiorendi]

Muon specific modules using l1extra collections have been cloned and migrated to new stage-2 L1t collections.

HLTMuonL1Filter → HLTMuonL1TFilter
HLTL1MuonSelector → HLTL1TMuonSelector
HLTMuonL1RegionalFilter → HLTMuonL1TRegionalFilter
HLTMuonTrkFilter → HLTMuonTrkL1TFilter
HLTMuonL1toL3TkPreFilter → HLTMuonL1TtoL3TkPreFilter

HLTMuonL2ToL1Map → HLTMuonL2ToL1TMap
HLTMuonL2PreFilter → HLTMuonL2FromL1TPreFilter
HLTMuonDimuonL2Filter → HLTMuonDimuonL2FromL1TFilter

RecoMuon/L2MuonSeedGenerator/L2MuonSeedGenerator → L2MuonSeedGeneratorFromL1T

An update was also needed for
DataFormats/MuonSeed/interface/L3MuonTrajectorySeed.h
DataFormats/MuonSeed/interface/L2MuonTrajectorySeed.h

[cmsbuild]

A new Pull Request was created by @sarafiorendi for CMSSW_8_0_X.

It involves the following packages:

DataFormats/MuonSeed
HLTrigger/Muon
RecoMuon/L2MuonSeedGenerator

@perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @Martin-Grunewald, @bellan, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

Is the implementation really so different to justify cloned implementation?
It may be better to have updates to existing modules.

On the other hand, this is all just the trigger code.
So, continuing support and bugfixing to the past is going to be limited in time while comparisons are needed between the two and the newer one happens to need an update like a bug fix.

@battibas @jhgoh @HuguesBrun please confirm that this cloning decision was well discussed in muon POG.

[slava77]

please change 13 to 12.
We should not skip versions.

[slava77]

review of cloned code is also more complicated: you will get more comments

[cmsbuild]

Pull request #13572 was updated. @perrotta, @cmsbuild, @cvuosalo, @fwyzard, @Martin-Grunewald, @deguio, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

[Martin-Grunewald]

please test

[slava77]

please clean up the git history from other PR merges.
The last commit dragged in 30K lines of changes.

[slava77]

-1

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #13572 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11776/console

[cmsbuild]

+1
Tested at: 46b53dd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13572/11776/summary.html

[Martin-Grunewald]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13572/11776/summary.html

[slava77]

+1

for #13572 46b53dd

• code changes are OK, although less code replication is desirable
• jenkins tests pass and comparisons with baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1