cleaning static analyzer warnings

[tmrhombus]

No description provided.

[cmsbuild]

A new Pull Request was created by @tmrhombus (T.M.Perry) for CMSSW_8_1_X.

It involves the following packages:

RecoJets/JetAnalyzers

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @TaiSakuma, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

why is this (HORecHitCollection loop) commented out?

[tmrhombus]

I commented it out because the only thing it did was loop. There was a cout stamement that this loop could have engaged, but that was already commented out in the code as I found it. The code was effectively:

for(i in collection){
// cout<<"we have the collection"<<endl;
}

I went the step further to say that there is no point in looping.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11699/console

[cmsbuild]

+1
Tested at: 3b7fda8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13585/11699/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13585/11699/summary.html

[cvuosalo]

+1

For #13585 3b7fda8

Minor code clean-up of some JetAnalyzer files. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-03-03-1100 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar