Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gsf cleanup and debug #13594

Merged
merged 19 commits into from Mar 8, 2016
Merged

Gsf cleanup and debug #13594

merged 19 commits into from Mar 8, 2016

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Mar 4, 2016

mostly cleanup of Gif code and re-enacting debug
no regression expected besides usual negligible diff due to numeric precision

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_8_1_X.

It involves the following packages:

CommonTools/RecoAlgos
DataFormats/Math
RecoParticleFlow/PFTracking
RecoTracker/TrackProducer
SimGeneral/TrackingAnalysis
TrackingTools/GsfTools
TrackingTools/GsfTracking
TrackingTools/KalmanUpdators
Validation/RecoTrack

@civanch, @cvuosalo, @mdhildreth, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @abbiendi, @mmarionncern, @battibass, @ahinzmann, @jhgoh, @lgray, @jdolen, @cerati, @trocino, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @wmtford, @mschrode, @dgulhan, @makortel, @gpetruc, @istaslis, @bachtis this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

Pull request #13594 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

@VinInn
Copy link
Contributor Author

VinInn commented Mar 4, 2016

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11716/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

@slava77
Copy link
Contributor

slava77 commented Mar 7, 2016

+1

for #13594 d99ca5b

  • changes in the code are in line with the description
  • jenkins tests pass and comparisons with baseline show small differences (expected)
  • tested locally in CMSSW_8_1_X_2016-03-04-2300 with more workflows and more events processed. The observations made in jenkins comparisons are confirmed.
    • in most cases differences start from electronGsfTracks and propagate downstream
    • occasionally also in b-tag vertex IP info and in tev muon refits (this is likely from the change in TrackingTools/KalmanUpdators/BuildFile.xml)
  • CPU use in workflow 25202 is roughly unchanged; there is about 2% decrease in electronGsfTracks CPU time (electronGsfTracks by itself is about 2% of reco time)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants