Fraction noisy channels #13595
Fraction noisy channels #13595
Conversation
|
A new Pull Request was created by @fcavallo (Francesca Romana Cavallo) for CMSSW_8_1_X. It involves the following packages: DQM/DTMonitorClient @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
can this PR be closed or are there problems? |
| const DTSuperLayer * SL = (muonGeom->chamber(chID))->superLayer(isl); | ||
| for (int ilay=1; ilay<5; ilay++) { | ||
| int nw = ((SL->layer(ilay))->specificTopology()).channels(); | ||
| NwCh[3][3]+=nw; |
There was a problem hiding this comment.
this numbers ([3][3]) look like magic numbers to me. is this wanted?
There was a problem hiding this comment.
hi, sorry I took so long!
Yes: it is wanted. And also: NwCh[9][3]+=nw; at line 123!
[3][3] means: sector 4, station 4. This DT station (and also MB4/Sect10, i.e. [9][3] here) is actually a pair of stations and in the software the twins are often treated as one, as it is the case in this class. You see for instance:
if(sector == 13) {
sector = 4;
} else if(sector == 14) {
sector = 10;
}
https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/DQM/DTMonitorClient/src/DTNoiseAnalysisTest.cc#L140
13 and 14 are the fictitious sector numbers of the twins. So here I am adding the wires of MB4/Sect13 to MB4/Sect4 and MB4/Sect14 to MB4/Sec10, to properly handle them as one, as they are in the rest of the code.
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
+1 |
Normalize the number of noisy channels to the total number of wires per chamber or sector