bsunanda:Phase2 hgx41Validation code due to Maksat

[bsunanda]

This watches steps in simulation and prepares data for validating geometry and hits

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

SimDataFormats/ValidationFormats
Validation/HGCalValidation

@civanch, @mdhildreth, @cmsbuild, @deguio, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @kpedro88, @lgray, @cseez, @pfs this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11774/console

[cmsbuild]

+1
Tested at: b6a9904
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13626/11774/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13626/11774/summary.html

[cmsbuild]

Pull request #13626 was updated. @civanch, @mdhildreth, @cmsbuild, @deguio, @vanbesien, @davidlange6 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11787/console

[cmsbuild]

+1
Tested at: b593268
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13626/11787/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13626/11787/summary.html

[civanch]

+1
Now the test is working but the sub-package requires clean-up of the directory structure

[bsunanda]

@deguio Please review the code and approve. Do you want us to explain this in some meeting?

[deguio]

ciao @bsunanda
sorry for being late.
it is not fully clear why the class SimG4HGCalValidation.cc should go in the Validation code. normally we accept only analyzers that book histograms there. is the addition of a plotting step foreseen for those products?

F.

[bsunanda]

Yes - of course. Maksat is preparing the code for plots - that part of the code is being tested right now.

---

From: Federico De Guio [notifications@github.com]
Sent: 15 March 2016 09:50
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Phase2 hgx41Validation code due to Maksat (#13626)

ciao @bsunandahttps://github.com/bsunanda
sorry for being late.
it is not fully clear why the class SimG4HGCalValidation.cc should go in the Validation code. normally we accept only analyzers that book histograms there. is the addition of a plotting step foreseen for those products?

F.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#13626 (comment)

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[bsunanda]

@davidlange6 Could you please merge this. We would like to add some addition on top of this soon.

[davidlange6]

+1