Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMTF DQM Module for CMSSW_8_1_X #13630

Merged
merged 1 commit into from Mar 9, 2016
Merged

EMTF DQM Module for CMSSW_8_1_X #13630

merged 1 commit into from Mar 9, 2016

Conversation

swang373
Copy link
Contributor

@swang373 swang373 commented Mar 7, 2016

The corresponding CMSSW_8_1_X version of the follow pull request: #13513.

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Mar 7, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

A new Pull Request was created by @swang373 (Sean-Jiun Wang) for CMSSW_8_1_X.

It involves the following packages:

DQM/Integration
DQM/L1TMonitor
DataFormats/L1TMuon
EventFilter/L1TRawToDigi

The following packages do not have a category, yet:

DataFormats/L1TMuon

@cmsbuild, @vanbesien, @mulhearn, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @threus, @batinkov this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@swang373 swang373 mentioned this pull request Mar 7, 2016
Closed
@deguio
Copy link
Contributor

deguio commented Mar 8, 2016

please test

@deguio
Copy link
Contributor

deguio commented Mar 8, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11771/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

+1
Tested at: aeba2b4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13630/11771/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13630/11771/summary.html

@mulhearn
Copy link
Contributor

mulhearn commented Mar 9, 2016

+1

@davidlange6
Copy link
Contributor

@smuzaffar @Degano - could you add DataFormats/L1TMuon to the L1 category. Thanks!

davidlange6 added a commit that referenced this pull request Mar 9, 2016
@davidlange6
Merge pull request #13630 from swang373/EMTF_DQM_dev_81X
0f6eb86 
EMTF DQM Module for CMSSW_8_1_X
@davidlange6 davidlange6 merged commit 0f6eb86 into cms-sw:CMSSW_8_1_X Mar 9, 2016
@swang373 swang373 deleted the EMTF_DQM_dev_81X branch March 9, 2016 13:19
@smuzaffar
Copy link
Contributor

done, cms-bot should recognize it after this comment

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@swang373 swang373 restored the EMTF_DQM_dev_81X branch March 16, 2016 11:52
@swang373 swang373 deleted the EMTF_DQM_dev_81X branch March 17, 2016 16:02
nsmith- added a commit to cms-l1t-offline/cmssw that referenced this pull request Mar 22, 2016
@nsmith-
Revert "First commit: compiles and runs"
3b69e64 
This reverts commit aeba2b4.
Also reverts PR cms-sw#13630
This is because it was merged before combo PR was created for 81X
Boy I wish we didn't need to combo these...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed l1-approved orp-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@swang373 @cmsbuild @deguio @mulhearn @davidlange6 @smuzaffar