Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add monitoring of tracks stopping source #13659

Merged
merged 3 commits into from Apr 26, 2016

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Mar 9, 2016

as suggested/requested in #13628
open in 80x

this PR is meant to add monitoring plots for the stopping source

3 plots (1 1D and 2 2D) are added in the general properties directories
3 plots (1 1D and 2 2D) x each step of the iterative tracking are added in the TrackBuilding directory

the 1D plot has 10bins (one per source type)
the 2D plots give this info as function of the track eta and phi, respectively (using the usual eta and phi binning)

@rovere @VinInn

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2016

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X.

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorSource

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@VinInn
Copy link
Contributor

VinInn commented Mar 9, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11803/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2016

@deguio
Copy link
Contributor

deguio commented Mar 24, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #13659 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@mtosi
Copy link
Contributor Author

mtosi commented Mar 29, 2016

as in PR #13637
I followed David suggestion, and fix the initialization of a vector

@deguio
Copy link
Contributor

deguio commented Apr 5, 2016

please test

@deguio
Copy link
Contributor

deguio commented Apr 5, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12192/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b2f4ec5 into cms-sw:CMSSW_8_0_X Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants