Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make statics thread local in TrackingTools/TrajectoryCleaning #1372

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 7, 2013

For thread safety, two non-const static variables are made thread local. These variables used to be on the stack, but were made static as a performance optimization.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2013

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

Make statics thread local in TrackingTools/TrajectoryCleaning

It involves the following packages:

TrackingTools/TrajectoryCleaning

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc, @cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2013

@thspeer
Copy link
Contributor

thspeer commented Nov 8, 2013

+1
Tested 8ebe041 in CMSSW_7_0_X_2013-11-08-0200-1372
No difference in reco, based on RelMon and reco scripts.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 10, 2013
…yCleaning

Multithreading fixes -- Make statics thread local in TrackingTools/TrajectoryCleaning
@ktf ktf merged commit bcc9213 into cms-sw:CMSSW_7_0_X Nov 10, 2013
@wmtan wmtan deleted the MakeStaticsThreadLocalInTrajectoryCleaning branch November 10, 2013 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants