New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Obsolete Header HideStdUniquePtrFromRoot.h #13745
Conversation
A new Pull Request was created by @wmtan for CMSSW_8_1_X. It involves the following packages: DataFormats/TrackerRecHit2D @smuzaffar, @Dr15Jones, @cvuosalo, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
-1 DAS Error you can see the results of the tests here: |
@cmsbuild @davidlange6 The DAS error in the relvals has noting to do with this PR. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Remove Obsolete Header HideStdUniquePtrFromRoot.h
Totally technical and trivial.
Back in the days of ROOT5 and CINT, gccxml did not understand C++11 constructs, such as std::unique_ptr. A header file, HideStdUniquePtrFromRoot.h, was written that defined our own
std::unique_ptr template that gccxml could understand.
In the ROOT6 world, this header is no longer needed, although for some reason an include of it still exists in one package,
This totally trivial and technical PR removes this obsolete unused header.