Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

barrel vs ladder in roc level in 80x #13758

Merged
merged 3 commits into from May 31, 2016

Conversation

gouskos
Copy link
Contributor

@gouskos gouskos commented Mar 17, 2016

add DQM plot for the pixel barrel.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gouskos for CMSSW_8_0_X.

It involves the following packages:

DQM/SiPixelMonitorTrack

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@deguio
Copy link
Contributor

deguio commented Apr 5, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12191/console

@deguio
Copy link
Contributor

deguio commented Apr 5, 2016

-1
see also #13759

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

-1
Tested at: 9e71577
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
----- Begin Fatal Exception 05-Apr-2016 20:57:31 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=SiPixelTrackResidualSource label='SiPixelTrackResidualSource_Cosmics'
Exception Message:
MissingParameter: Parameter 'digisrc' not found.
----- End Fatal Exception -------------------------------------------------

8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 05-Apr-2016 20:59:10 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=SiPixelTrackResidualSource label='SiPixelTrackResidualSource_Cosmics'
Exception Message:
MissingParameter: Parameter 'digisrc' not found.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13758/12191/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

Pull request #13758 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@gouskos
Copy link
Contributor Author

gouskos commented Apr 6, 2016

Pull request is updated according to your instructions

@deguio
Copy link
Contributor

deguio commented Apr 19, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12481/console

@cmsbuild
Copy link
Contributor

@boudoul
Copy link
Contributor

boudoul commented Apr 28, 2016

hi @gouskos , could you please remove the cout ? Thanks

@cmsbuild
Copy link
Contributor

Pull request #13758 was updated. @cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented May 4, 2016

please test

@deguio
Copy link
Contributor

deguio commented May 4, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12814/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

@fioriNTU
Copy link
Contributor

@deguio @davidlange6 can we have this PR merged, it is very important to monito bad channels in Pixels, in the case the 80X is already closed, can we have #13759 back ported?

@vanbesien
Copy link
Contributor

@dmitrijus

@boudoul
Copy link
Contributor

boudoul commented May 31, 2016

hi @davidlange6 , can this PR be merged ? The equivalent in 81X PR #13759 has already been merged some time ago - thanks a lot.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c48d2d0 into cms-sw:CMSSW_8_0_X May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants