Adding new detectors - integration of RomanPot detectors for CTPPS project

[grzanka]

Integration of RomanPot (RP) detectors for CTPPS.
DetId=7 refers to the standard sequence of Totem RP + Si Strips sensors.
These detectors are required in the early runs of CTPPS (2016 start of run).
DetId=8 refers to the baseline setup of CTPPS with new 3D pixel sensors (operative end of 2016)
and Timing sensors (operative mid 2016) installed in a new Roman Pot.

The reason to have two DetId is to avoid possible clashes

[cmsbuild]

A new Pull Request was created by @grzanka (Leszek Grzanka) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/DetId

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

@civanch I have asked for this to come in a separate PR due to its simplicity and also a large chain of dependencies to recompile, including about a half of CMSSW.
Prompt review would be nice.
Thanks.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11950/console

[grzanka]

@slava77 Will we be able to see results of Jenkins tests ? When I go to https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11950/console, I get "Authorization failed" message.

[slava77]

@grzanka
jenkins console just shows work in progress.
You'd be more interested to see the results when they come out (it will be a separate message from cmsbuild)
Let's see if you can open any of those (I'll send an email)

[slava77]

@grzanka
please edit the PR title ("Edit" button should be at the top) and add a more specific note that this is for detector enum, e.g., add ": add 2 detector enums"

[grzanka]

@slava77 is the title better now ?

[slava77]

On 3/17/16 1:11 PM, Leszek Grzanka wrote:

@slava77 https://github.com/slava77 is the title better now ?

Yes.
Thank you.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#13766 (comment)

[cmsbuild]

-1

Tested at: 39f7e69
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13766/11950/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
64a9f14
b0e6bb9
72b15df
5765eb1
6bb47c7
bd2081e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13766/11950/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13766/11950/git-merge-result

[slava77]

runtestTqafTopEventSelection has errors in the IB. So, not related to this PR.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13766/11950/summary.html

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11961/console

[davidlange6]

Naively I would prefer one "detector" and then sub detectors. how many sub detectors are expected to be defined for these two new "detector"s?

[cmsbuild]

-1

Tested at: 39f7e69
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13766/11961/summary.html

[civanch]

@grzanka , if it is possible, would be ideal implementing David request to have only one DetId TOTEM not two. In other cases (HCAL, for example) we have several sub-detectors as well and there are different level of upgrades.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13766/11961/summary.html

[cmsbuild]

Pull request #13766 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.