Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring L1T emulation up to date with l1t-tsg-v4 tag #13768

Merged
merged 241 commits into from Apr 1, 2016
Merged

Bring L1T emulation up to date with l1t-tsg-v4 tag #13768

merged 241 commits into from Apr 1, 2016

Conversation

mulhearn
Copy link
Contributor

mulhearn and others added 30 commits February 9, 2016 12:14
@mulhearn
update L1T standard sequences
5406f87
@mulhearn
cleanup summary module and related customs
d8e4835
@mulhearn
add ReEmul customization for cmsDriver workflows and more utilities
b0824f2
@tstreble @mulhearn
Update EG isolation + Tau calibration LUTs
7dcb5dc
@bundocka @mulhearn
Fixed HBHENoiseFilterResult
3d742d9
@mulhearn
new emulator for calo layer1
8fc7039
@mulhearn
unpacker for calo layer1
c168773
@SridharaDasu @mulhearn
Added HF 1x1 handling
dae3208
@SridharaDasu @mulhearn
Added HF tower handling
e12adb7
@SridharaDasu @mulhearn
Fixed so HF TPs are appended to regular collection with version set to 1
0be1a05
@SridharaDasu @mulhearn
Removed empty hfTPGDigis stub :(
9734d82
@SridharaDasu @mulhearn
Added access to uctPhi() from tower for correct CaloTower making
4b1cedf
@SridharaDasu @mulhearn
Added run number and dataset selection ability at run time to test sc…
91b0a53 
…ript - thanks Nick Smith
@mulhearn
move test code out of deprecated L1TCaloLayer1RawToDigi
6bfc69b
@mulhearn
remove deprecated EventFilter/L1TCaloLayer1RawToDigi
2bd812a
@mulhearn
fix l1t text summary in example code
2865eac
@mulhearn
make L1TCaloLayer1 a drop in replacement, leave off by default
3489e9e
@davignon @mulhearn
Added Options 4 and 5 isolation LUTs for taus
5897e1b 
Conflicts:
	L1Trigger/L1TCalorimeter/data/Flat_Tau_iso_LUT_eff70.txt
	L1Trigger/L1TCalorimeter/data/Flat_Tau_iso_LUT_eff80.txt
	L1Trigger/L1TCalorimeter/data/Flat_Tau_iso_LUT_eff90.txt
@mulhearn
quiet verbose reEmul example
fe177ee
@mrcarver @mulhearn
Added absolute value operator to z-coordinate variable
faf8e0a
@mulhearn
disable GMT regional muon packing until fixed
df59949
@mulhearn
bugfix for standard sequences for pre6
0aa725f
@mulhearn
remove unsupported examples
d5352f6
@mulhearn
bugfix summary output and remove obsolete customs
3f8977c
@mulhearn
add muons to emulation ntuple
2e2000a
@mulhearn
re-emulate HCAL TPs by default in reEmul custom
e95c1eb
@mulhearn
remove inadvertent override of HCAL TP re-emulation
4f28e8c
@thomreis @mulhearn
Check the size of the track address map before using it when builting…
74785f1 
… the raw track address.
@thomreis @mulhearn
Bugfix: Every BX, not just the first one, is now filled with 6 empty …
66fd6f6 
…muons if no muon was in the BX.
@akalinow @mulhearn
* make get methods of L1TMuonOverlapParams to be const
0531a74 
* the phi angle converions follows hardware mroe closely
@cmsbuild
Copy link
Contributor

Pull request #13768 was updated. @cerminar, @cmsbuild, @rekovic, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

@mulhearn
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12123/console

@cmsbuild
Copy link
Contributor

Pull request #13768 was updated. @cerminar, @cmsbuild, @rekovic, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

@mulhearn mulhearn mentioned this pull request Mar 31, 2016
Open
@mulhearn
Copy link
Contributor Author

That last commit covers (I believe) all requests except those we are requesting to punt on, tracked here cms-l1t-offline#220

@mulhearn
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2016

+1
Tested at: 65b0bdd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13768/12123/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13768/12123/summary.html

@davidlange6
Copy link
Contributor

merging in for the 1100 IB - lets see how it goes.

@davidlange6 davidlange6 merged commit 6d75c5e into cms-sw:CMSSW_8_1_X Apr 1, 2016
@rekovic
Copy link
Contributor

rekovic commented Apr 4, 2016

@davidlange6 Could this be also back-ported to 80X?
Or would we have to resurrect #13767, which is a PR with a different branch.

@mulhearn, @Martin-Grunewald, this interests you.

@Martin-Grunewald
Copy link
Contributor

@rekovic
Well, I thought #13767 IS the equivalent backport PR for 80X to this 81XPR!
????

@Martin-Grunewald
Copy link
Contributor

@rekovic
Does #13767 miss the most recent commits of this PR?

@rekovic
Copy link
Contributor

rekovic commented Apr 4, 2016

@Martin-Grunewald #13767 is missing the latest OMTF EMTF fixes, etc. @mulhearn can you comment?

@Martin-Grunewald
Copy link
Contributor

Well, then could we make a new PRs for those, for 80X and 81X?

@rekovic
Copy link
Contributor

rekovic commented Apr 4, 2016

@Martin-Grunewald
By "latest OMTF EMTF fixes", I meant the latest commits of code clean-up listed in this 81x PR and already merged 3 days ago after @mulhearn cleaned 81x code. I imagine he will do the same clean-up for 80x and make a 80x PR. Let's wait for his comment.

@mulhearn
Copy link
Contributor Author

mulhearn commented Apr 5, 2016

PR for 80x was updated to bring in sync with this one. Testing now.

@mulhearn mulhearn deleted the pr-l1t-tsg-v4-81x branch April 5, 2016 10:30
@perrotta perrotta mentioned this pull request Apr 5, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending comparison-available db-pending l1-approved orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet