Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in L1T Calo packers - useful for data taking - 81x #13787

Merged
merged 3 commits into from Mar 22, 2016
Merged

Fixes in L1T Calo packers - useful for data taking - 81x #13787

merged 3 commits into from Mar 22, 2016

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Mar 21, 2016

Fixed EG Unpacker and EtSums Unpacker and Emulation to agree with packer.
Now Unpacked and Re-emulated L1T decisions in HLT are in agreement.
Should use this in data taking immediately.

mulhearn and others added 2 commits March 21, 2016 09:13
@mulhearn @rekovic
fix etSums order in packer and emulator, to match unpacker, and resto…
e7aac53 
…re bitwise test of sums

Conflicts:
	L1Trigger/L1TCommon/python/l1tComparisonStage2RAWvsEMU_cfi.py
@tstreble @rekovic
Fixed EG Packer
6364eec
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Mar 21, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_8_1_X.

It involves the following packages:

EventFilter/L1TRawToDigi
L1Trigger/L1TCalorimeter
L1Trigger/L1TCommon

@cmsbuild, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@rekovic
Copy link
Contributor Author

rekovic commented Mar 21, 2016

please test

@rekovic
Copy link
Contributor Author

rekovic commented Mar 21, 2016

Can somebody ping jenkins for me, please.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11987/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 6364eec
When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13787/11987/summary.html

@fwyzard
Copy link
Contributor

fwyzard commented Mar 21, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11993/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11996/console

@rekovic
Copy link
Contributor Author

rekovic commented Mar 21, 2016

@davidlange6 Looking at the log
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13787/11987/runTheMatrix-results/matrixTests.log
the failing test seem to be

(das_client.py --cache das-cache.file --limit 0 --query 'file dataset=/Cosmics/Run2011A-v1/RAW run=160960 site=T2_CH_CERN') | sort -u > step1_dasquery.log  2>&1

Running it locally simply creates a list of files. What am I missing?

@davidlange6
Copy link
Contributor

please test

das failed. It happens. not much jenkins can do about it - so lets rerun the tests.

On Mar 21, 2016, at 4:36 PM, rekovic notifications@github.com wrote:

@davidlange6 Looking at the log
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13787/11987/runTheMatrix-results/matrixTests.log
the failing test seem to be

(das_client.py --cache das-cache.file --limit 0 --query 'file dataset=/Cosmics/Run2011A-v1/RAW run=160960 site=T2_CH_CERN') | sort -u > step1_dasquery.log 2>&1

Running it locally simply creates a list of files. What am I missing?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@rekovic
Copy link
Contributor Author

rekovic commented Mar 21, 2016

ok. thanks.

@cmsbuild
Copy link
Contributor

+1
Tested at: 6364eec
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13787/11996/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13787/11996/summary.html

@cmsbuild
Copy link
Contributor

Pull request #13787 was updated. @cmsbuild, @mulhearn, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12006/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 3592e35
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13787/12006/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13787/12006/summary.html

davidlange6 added a commit that referenced this pull request Mar 22, 2016
@davidlange6
Merge pull request #13787 from cms-l1t-offline/l1t-fixCaloPack-80x
d19277c 
Fixes in L1T Calo packers - useful for data taking - 81x
@davidlange6 davidlange6 merged commit d19277c into cms-sw:CMSSW_8_1_X Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available l1-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rekovic @cmsbuild @Martin-Grunewald @fwyzard @davidlange6 @mulhearn @tstreble