New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geant4.9.6ref10 backward compatible modifications #1382
Conversation
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_0_X. Geant4.9.6ref10 It involves the following packages: SimG4Core/Geometry @civanch, @nclopezo, @demattia, @mdhildreth, @cmsbuild, @rcastello, @giamman can you please review it and eventually sign? Thanks. |
Pull request #1382 was updated. @civanch, @nclopezo, @demattia, @mdhildreth, @cmsbuild, @rcastello, @giamman can you please check and sign again. |
Pull request #1382 was updated. @civanch, @nclopezo, @demattia, @mdhildreth, @cmsbuild, @rcastello, @giamman can you please check and sign again. |
-1 >> Compiling /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/SimG4Core/PhysicsLists/src/CMSFTFPProtonBuilder.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/SimG4Core/PhysicsLists/src/CMSG4mplIonisation.cc In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/SimG4Core/SensitiveDetector/interface/SensitiveTkDetector.h:5:0, from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/SimG4CMS/Tracker/interface/TkAccumulatingSensitiveDetector.h:9, from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/Alignment/LaserAlignmentSimulation/plugins/LaserAlignmentSimulation.cc:22: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/SimG4Core/SensitiveDetector/interface/SensitiveDetector.h:25:37: error: expected ')' before '&' token explicit SensitiveDetector(string & iname, const DDCompactView & cpv, ^ /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/SimG4Core/SensitiveDetector/interface/SensitiveDetector.h:34:25: error: 'string' has not been declared virtual void AssignSD(string & vname); ^ you can see the results of the tests here: |
Pull request #1382 was updated. @demattia, @civanch, @mdhildreth, @rcastello, @giamman can you please check and sign again. |
The previous tests were triggered before the commit 36dcb1b was pushed, I will trigger them again. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Geant4.9.6ref10 -- backward compatible modifications
Addition explicit headers from CLHEP units and physics consttants. THis modification should have no effect on any test result.