Added edtoken to EcalDumpRaw

[argiro]

Conform EcalDumpRaw to getByToken

[cmsbuild]

A new Pull Request was created by @argiro for CMSSW_8_1_X.

It involves the following packages:

EventFilter/EcalRawToDigi

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12119/console

[cmsbuild]

+1
Tested at: 5f390bf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13876/12119/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13876/12119/summary.html

[cvuosalo]

@argiro: EcalDumpRaw.h still has inheritance from EDAnalyzer:
class EcalDumpRaw : public edm::EDAnalyzer {
Doesn't the base class need to be changed to a thread-safe version like edm::stream::EDAnalyzer<>?

[argiro]

it's sort of a technical tool used by experts, does not go into production sequences, but I can change the inheritance

On 01 Apr 2016, at 23:25, Carl Vuosalo notifications@github.com wrote:

@argiro: EcalDumpRaw.h still has inheritance from EDAnalyzer:
class EcalDumpRaw : public edm::EDAnalyzer {
Doesn't the base class need to be changed to a thread-safe version like edm::stream::EDAnalyzer<>?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

[cvuosalo]

@argiro: Since you're cleaning up the code, you might as well fix the EDAnalyzer inheritance so the issue is no longer flagged by the static analyzer.

[cmsbuild]

Pull request #13876 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12175/console

[cmsbuild]

+1
Tested at: fd3780f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13876/12175/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13876/12175/summary.html

[cvuosalo]

+1

For #13876 fd3780f

Revising EcalDumpRaw to use getByToken. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-04-04-2300 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1