Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VID MVA headers in plugin directory - 80X version #13910

Merged
merged 1 commit into from Apr 12, 2016

Conversation

rafaellopesdesa
Copy link
Contributor

This is related to this hypernews thread:

https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3321.html

Loading the plugin in the .cc file and moving the .h file to the plugin directory. Similar PR will be done for 76X and 81X

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

A new Pull Request was created by @rafaellopesdesa (Rafael Lopes de Sa) for CMSSW_8_0_X.

It involves the following packages:

RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Apr 4, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12153/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 4, 2016

+1

For #13910 e11197e

Small technical fix for VID MVA headers. There should be no change in monitored quantities.

#13909 and #13911 are the 76X and 81X versions of this PR, and the former has already been approved.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-04-03-0000 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b9a53a3 into cms-sw:CMSSW_8_0_X Apr 12, 2016
@rafaellopesdesa rafaellopesdesa deleted the plugin_fix_VID_80X branch February 1, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants