Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to 2016 era and 2016 hlt where it is working in relvals #13919

Merged
merged 68 commits into from Apr 4, 2016

Conversation

davidlange6
Copy link
Contributor

move to 2016 era and 2016 hlt where it is working

Eventually we need also fastsim to be updated (it crashes now), and also a small dedicated set of 2015 MC relvals.

This PR includes #13863 and #13892

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_8_1_X.

It involves the following packages:

Configuration/AlCa
Configuration/HLT
Configuration/PyReleaseValidation
Configuration/Skimming
HLTrigger/Configuration
HLTrigger/HLTcore
HLTrigger/HLTfilters
L1Trigger/L1TGlobal
Utilities/ReleaseScripts

@perrotta, @smuzaffar, @Dr15Jones, @franzoni, @cerminar, @fabozzi, @Martin-Grunewald, @rekovic, @srimanob, @cmsbuild, @fwyzard, @mmusich, @hengne, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @wddgit, @Martin-Grunewald, @tocheng, @jalimena, @geoff-smith this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlange6
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12164/console

@@ -1340,7 +1340,7 @@ def identityFS(wf):
'-s':'HARVESTING:@standardValidation+@standardDQM+@miniAODValidation+@miniAODDQM', # todo: remove UP from label
'--conditions':'auto:run2_mc',
'--mc':'',
'--era' : 'Run2_25ns',
'--era' : 'Run2_2016s',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this rather be Run2_2016 (instead of Run2_2016s)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops - yes - I fixed that once… thanks

On Apr 4, 2016, at 7:40 PM, Martin Grunewald notifications@github.com wrote:

In Configuration/PyReleaseValidation/python/relval_steps.py:

@@ -1340,7 +1340,7 @@ def identityFS(wf):
'-s':'HARVESTING:@standardValidation+@standardDQM+@miniAODValidation+@miniAODDQM', # todo: remove UP from label
'--conditions':'auto:run2_mc',
'--mc':'',

  • '--era' : 'Run2_25ns',
  • '--era' : 'Run2_2016s',

Should this rather be Run2_2016 (instead of Run2_2016s)?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12165/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

Pull request #13919 was updated. @perrotta, @smuzaffar, @Dr15Jones, @franzoni, @cerminar, @fabozzi, @Martin-Grunewald, @rekovic, @srimanob, @cmsbuild, @fwyzard, @mmusich, @hengne, @mulhearn, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

-1
Tested at: bf35212
When I ran the RelVals I found an error in the following worklfows:
1306.0 step4

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step4_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step4

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step4_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

25202.0 step4

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step4_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13919/12164/summary.html

@davidlange6 davidlange6 merged commit bd318d6 into cms-sw:CMSSW_8_1_X Apr 4, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

@smuzaffar
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

As sent to ORP:

Thanks for integration!

Looking at the IB CMSSW_8_1_X_2016-04-04-2300, the RelVal failures
with return code 35584 in step2 are mostly due to --era problems:
for HIon, --era should be updated from "--era Run2_HI" to
"--era Run2_2016,Run2_HI" , while for some pp workflows, "--era Run2_25ns"
is still used but should become "--era Run2_2016".

For 810pre2, please also include #13905 (L1T ext. cond.).

I see that FastSim workflows are still at @relval25ns/Run2_25ns and
thus now using the Fake1 menu. If you want to update that to use 
@relval2016 also, like fullsim, just insert a DIGI2RAW after step L1
and before step L1Reco in the fastsim cmsDriver cmd, besides the
era modification to become "--era Run2_2016".

IOW: either @relval25ns with --era Run2_25ns, or @relval2016 with --era
Run2_2016

@davidlange6
Copy link
Contributor Author

davidlange6 commented Apr 5, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants