New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SiPixelDigiValid::analyse: blade number fix #13986
Conversation
A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_8_1_X. It involves the following packages: Validation/TrackerDigis @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
This PR fixes #13858.
The number of blades (and also ladders) is read from the GeometricSearchTracker structure. This means there is a new dependency to RecoTracker.
While the changes do fix the crash caused by the geometry dependence of this code, they do not fix the actual problem. The change to the ladder counts is more cosmetic to be consistent with the analogous blade counts; it should remove a number of false 0 entries from the result, but the result is not very meaningful for the upgraded detector anyways.