Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiPixelDigiValid::analyse: blade number fix #13986

Merged
merged 2 commits into from Apr 11, 2016

Conversation

schneiml
Copy link
Contributor

@schneiml schneiml commented Apr 7, 2016

This PR fixes #13858.

The number of blades (and also ladders) is read from the GeometricSearchTracker structure. This means there is a new dependency to RecoTracker.

While the changes do fix the crash caused by the geometry dependence of this code, they do not fix the actual problem. The change to the ladder counts is more cosmetic to be consistent with the analogous blade counts; it should remove a number of false 0 entries from the result, but the result is not very meaningful for the upgraded detector anyways.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_8_1_X.

It involves the following packages:

Validation/TrackerDigis

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@deguio
Copy link
Contributor

deguio commented Apr 10, 2016

please test

@deguio
Copy link
Contributor

deguio commented Apr 10, 2016

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12268/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e1e7bbd into cms-sw:CMSSW_8_1_X Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants