Cleanup sim mergeable products #13993
Conversation
Removed the typedef weights_defs in LHERunInfoProduct since it is not used anywhere in CMSSW.
The GenRunInfoProduct had a mergeProduct method which signaled to the framework that this product has to be merged within a Run. However, the method itself did not actually merge so all that is needed is the isProductEqual method. In addition, since no classes inherit from this class, all methods are now non-virtual.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: SimDataFormats/GeneratorProducts @cmsbuild, @covarell, @govoni, @thuer, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
@bendavid @syuvivida do you see any problem with this? |
|
This looks ok to me (but doesn't solve the issue for LHERunInfoProduct where it is both more critical and also more difficult to fix in a way which maintains compatibility both with existing samples and with the current wmLHE workflow) |
|
@covarell I don't have problem with this. GenLumiInfo is not dependent on GenRunInfo. |
| externalXSecNLO_ == other.externalXSecNLO_ && | ||
| externalFilterEfficiency_ == other.externalFilterEfficiency_; | ||
| if( not result) { | ||
| edm::LogWarning("GenRunInfoProduct|ProductsNotMergeable") |
There was a problem hiding this comment.
@Dr15Jones - why not throw on this condition?
There was a problem hiding this comment.
As discussed in the Core meeting, the framework is not expecting this routine to throw and will handle the error when this function returns false.
Made non-critical changes to Sim Run products in order to clean them up. Removing the non-useful isMergeable method of GenRunInfoProduct will allow this product to be read at beginRun time and avoids the framework difficulties with mergeable run products.