fix QIE10 shape: bins start at -0.5 #13998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_0_X. It involves the following packages: CondFormats/HcalObjects @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
@mmusich can you also sign this one? |
|
+1 |
|
@davidlange6 - can you merge this one too? |
|
we'll see that this all works in 81x (yes, it should be no problem..) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dnoonan08 found that the QIE10 shape in CMSSW was not consistent with the calibration procedure that will be used for the QIE10. Starting the bins at -0.5 instead of -1 produces a consistent conversion between fC and ADC. This PR was backported from 81X.