Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize lastModuleIndex to 0 #14001

Merged
merged 1 commit into from Apr 12, 2016
Merged

Initialize lastModuleIndex to 0 #14001

merged 1 commit into from Apr 12, 2016

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Apr 9, 2016

While compiling with GCC 6.0.0 (r234771) in C++1z mode compiler produces
extra diagnostic:

FWCore/Framework/src/Schedule.cc:1372:43: error: 'lastModuleIndex'

may be used uninitialized in this function [-Werror=maybe-uninitialized]

Initialize lastModuleIndex to 0.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Initialize lastModuleIndex to 0
c5b1291 
While compiling with GCC 6.0.0 (r234771) in C++1z mode compiler produces
extra diagnostic:

    FWCore/Framework/src/Schedule.cc:1372:43: error: 'lastModuleIndex'
may be used uninitialized in this function [-Werror=maybe-uninitialized]

Initialize lastModuleIndex to 0.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 9, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2016

A new Pull Request was created by @davidlt for CMSSW_8_1_X.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12273/console

@cmsbuild
Copy link
Contributor

+1
Tested at: c5b1291
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14001/12273/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14001/12273/summary.html

@Dr15Jones
Copy link
Contributor

+1
Although the code is fine since access the uninitialized value is protected by the value of the other variable. But best to silence the warning.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6ae363a into cms-sw:CMSSW_8_1_X Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidlt @cmsbuild @davidlange6 @Dr15Jones