The return values of gSystem->Load(library) can be 0 or 1.

[gartung]

The current check for 0 causes an error when the return code is 1.

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X.

It involves the following packages:

FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[gartung]

@Dr15Jones @smuzaffar @davidlt @davidlange6

[cmsbuild]

Pull request #14022 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12320/console

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

are the exit codes documented someplace? (e.g., there are really no bad exit codes >1)

[gartung]

https://root.cern.ch/root/html604/TSystem.html#TSystem:Load

[Dr15Jones]

It does look like ROOT is using negative values for failures

[cmsbuild]

+1
Tested at: 069d7ad
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14022/12320/summary.html

[davidlange6]

+1
thanks