Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More general form of valid hit in pixel function (81X) #14027

Merged
merged 6 commits into from Apr 28, 2016
Merged

More general form of valid hit in pixel function (81X) #14027

merged 6 commits into from Apr 28, 2016

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Apr 12, 2016

Functions that check if there are valid hits in the second and third pixel (barrel/endcap) layer.

In response to #13744 (comment)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_8_1_X.

It involves the following packages:

DQM/TrackingMonitor
DataFormats/TrackReco
ElectroWeakAnalysis/ZEE
PhysicsTools/PatAlgos
RecoBTag/TrackProbability
RecoEgamma/ElectronIdentification
RecoVertex/PrimaryVertexProducer

@cvuosalo, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @TaiSakuma, @threus, @mmarionncern, @imarches, @makortel, @acaudron, @lgray, @jdolen, @ferencek, @cerati, @Sam-Harper, @GiacomoSguazzoni, @rafaellopesdesa, @rovere, @VinInn, @nhanvtran, @schoef, @dgulhan, @ahinzmann, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Apr 12, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12298/console

@cmsbuild
Copy link
Contributor

-1

Tested at: db43178
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14027/12298/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
db43178
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14027/12298/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14027/12298/git-merge-result

@cmsbuild
Copy link
Contributor

@dildick
Copy link
Contributor Author

dildick commented Apr 12, 2016

The unit test error was also seen here #13744 (comment). It is not related to this PR.

@slava77
Copy link
Contributor

slava77 commented Apr 14, 2016

+1

for #14027 db43178

@deguio
Copy link
Contributor

deguio commented Apr 22, 2016

+1

@davidlange6 davidlange6 merged commit 6f220f2 into cms-sw:CMSSW_8_1_X Apr 28, 2016
@dildick dildick deleted the second-third-pixel-layer-hits-81X branch April 30, 2016 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants