Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muon dqm mini aod 81 #14059

Merged
merged 16 commits into from Nov 2, 2016
Merged

Muon dqm mini aod 81 #14059

merged 16 commits into from Nov 2, 2016

Conversation

sscruz
Copy link
Contributor

@sscruz sscruz commented Apr 14, 2016

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sscruz for CMSSW_8_1_X.

It involves the following packages:

DQMOffline/Configuration
DQMOffline/Muon

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic, @battibass, @threus, @abbiendi, @jhgoh, @bellan, @trocino, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@folguera folguera mentioned this pull request Apr 27, 2016
@deguio
Copy link
Contributor

deguio commented Apr 30, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 30, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12741/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #14059 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16114/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

@folguera
Copy link
Contributor

folguera commented Nov 1, 2016

@slava77, @davidlange6, @smuzaffar, could you please check and approve?

@davidlange6
Copy link
Contributor

+1
@Dr15Jones - please confirm that this does not cause scheduling issues in DEVEL in the next IB...

@cmsbuild cmsbuild merged commit 1f6ae77 into cms-sw:CMSSW_8_1_X Nov 2, 2016
@Dr15Jones
Copy link
Contributor

In theory, the schedule validator in CMSSW_8_1 should identify cases that would cause problems in _DEVEL and thrown an exception. Unfortunately, there are some know cases it can miss. However, the crux of the problems are

  • a module on a Path needs data that only comes from an EndPath or
  • a module on a Path wants to get the TriggerResults from this job

As far as I can tell, neither of those appears to be the case for changes from this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants