Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix closing lumisection in HLT(DAQ) when stop requested for Cloud switchover (80X) #14125

Merged
merged 1 commit into from Apr 19, 2016

Conversation

smorovic
Copy link
Contributor

Fix for a bug appearing with high ramdisk access latency
(exceptional condition that does not happen normally, but is a result of some other problem, usually network / NFS) whene LS value given by CMSSW_STOP file
(created by hltd usually when cloud switch is made mid-run) is older than the current LS processed by CMSSW.

In this condition, end run in can happen in the mid of current LS, which
rarely resulted in not writing EoLS file to disk and thus causing lumisection to remain unmerged on FU.

This patch sets higher "stop LS" value with which current LS is properly closedr (EoLS file gets written out as in the usual case).

…ndition that does not happen normally, but is a result of some other problem), LS value given by CMSSW_STOP file

(created by hltd usually when cloud switch is made mid-run) is older than the current LS processed by CMSSW. In that case it was possible to end run in the mid of current LS, which
rarely resulted in not writing EoLS file to disk and thus causing lumisection to remain unmerged on FU. This patch sets higher "stop LS" if in such condition.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_8_0_X.

It involves the following packages:

EventFilter/Utilities

@cvuosalo, @emeschi, @cmsbuild, @slava77, @mommsen, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mommsen
Copy link
Contributor

mommsen commented Apr 18, 2016

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12458/console

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14125/12458/summary.html

The workflows 1003.0, 134.911 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@davidlange6 davidlange6 merged commit b5e29c5 into cms-sw:CMSSW_8_0_X Apr 19, 2016
@smorovic smorovic deleted the fix-cloud-stop-80X branch February 13, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants