Use unique_ptr, not auto_ptr, in Generators #14169

wmtan · 2016-04-20T17:05:43Z

The last use of the deprecated std::auto_ptr in the CMS framework is the "put" interface for EDProducts, which also supports std::unique:ptr. This PR changes all put calls in generators to use std::unique_ptr instead of std::auto_ptr. Some other instances of std::auto_ptr in generators may also have been changed to std::unique_ptr.

cmsbuild · 2016-04-20T17:06:10Z

A new Pull Request was created by @wmtan for CMSSW_8_1_X.

It involves the following packages:

GeneratorInterface/AlpgenInterface
GeneratorInterface/BeamHaloGenerator
GeneratorInterface/Core
GeneratorInterface/CosmicMuonGenerator
GeneratorInterface/GenFilters
GeneratorInterface/HiGenCommon
GeneratorInterface/LHEInterface
GeneratorInterface/MCatNLOInterface
GeneratorInterface/Pythia6Interface
GeneratorInterface/RivetInterface
GeneratorInterface/TauolaInterface
IOMC/ParticleGuns

@cmsbuild, @covarell, @govoni, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@cbaus, @agrohsje, @mkirsano this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

wmtan · 2016-04-20T20:32:23Z

@cmsbuild please test

cmsbuild · 2016-04-20T20:32:41Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12528/console

cmsbuild · 2016-04-20T20:40:03Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2016-04-20T20:40:33Z

-1

Tested at: fffefc6

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14169/12528/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-20-1100/src/GeneratorInterface/ReggeGribovPartonMCInterface/src/sibyll_21.f 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-20-1100/src/GeneratorInterface/Core/interface/GenFilterEfficiencyProducer.h:20:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-20-1100/src/GeneratorInterface/Core/plugins/GenFilterEfficiencyProducer.cc:1:
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/FWCore/Framework/interface/LuminosityBlock.h: In instantiation of 'void edm::LuminosityBlock::put(std::unique_ptr<_Tp>) [with PROD = GenFilterInfo]':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-20-1100/src/GeneratorInterface/Core/plugins/GenFilterEfficiencyProducer.cc:132:35:   required from here
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/FWCore/Framework/interface/LuminosityBlock.h:113:50: error: use of deleted function 'std::unique_ptr<_Tp, _Dp>::unique_ptr(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = GenFilterInfo; _Dp = std::default_delete]'
     put(std::unique_ptr product) {put(product, std::string());}
                                                  ^
In file included from /cvmfs/cms-ib.cern.ch/2016-17/slc6_amd64_gcc530/external/gcc/5.3.0/include/c++/5.3.0/memory:81:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-20-1100/src/GeneratorInterface/Core/interface/GenFilterEfficiencyProducer.h:11,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-20-1100/src/GeneratorInterface/Core/plugins/GenFilterEfficiencyProducer.cc:1:

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 64 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-20-1100/src/GeneratorInterface/GenFilters/src/XtoFFbarFilter.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-20-1100/src/GeneratorInterface/GenFilters/src/NJetsMC.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-20-1100/src/GeneratorInterface/GenFilters/src/LQGenFilter.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-20-1100/src/GeneratorInterface/Core/plugins/GenFilterEfficiencyProducer.cc:1:
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-20-1100/src/GeneratorInterface/Core/interface/GenFilterEfficiencyProducer.h:20:
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/FWCore/Framework/interface/LuminosityBlock.h:113:51: error: call to deleted constructor of 'std::unique_ptr'
    put(std::unique_ptr product) {put(product, std::string());}
                                                  ^~~~~~~
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-20-1100/src/GeneratorInterface/Core/plugins/GenFilterEfficiencyProducer.cc:132:9: note: in instantiation of function template specialization 'edm::LuminosityBlock::put' requested here
  iLumi.put(std::move(thisProduct));
        ^

cmsbuild · 2016-04-20T20:47:57Z

Pull request #14169 was updated. @smuzaffar, @Dr15Jones, @thuer, @cmsbuild, @covarell, @govoni, @davidlange6 can you please check and sign again.

wmtan · 2016-04-20T20:49:44Z

@cmsbuild please test

cmsbuild · 2016-04-20T20:50:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12529/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12531/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12532/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12533/console

cmsbuild · 2016-04-21T04:56:15Z

-1

Tested at: bde3aa4

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14169/12531/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
9.0 step1

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Thu Apr 21 06:41:49 2016-date Thu Apr 21 06:38:21 2016 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 21 06:41:49 2016-date Thu Apr 21 06:38:21 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Thu Apr 21 06:41:49 2016-date Thu Apr 21 06:38:21 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Thu Apr 21 06:41:38 2016-date Thu Apr 21 06:38:27 2016 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 21 06:41:38 2016-date Thu Apr 21 06:38:27 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Thu Apr 21 06:41:38 2016-date Thu Apr 21 06:38:27 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_8TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Thu Apr 21 06:44:00 2016-date Thu Apr 21 06:41:43 2016 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 21 06:44:00 2016-date Thu Apr 21 06:41:43 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Thu Apr 21 06:44:00 2016-date Thu Apr 21 06:41:43 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Thu Apr 21 06:44:58 2016-date Thu Apr 21 06:41:58 2016 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 21 06:44:58 2016-date Thu Apr 21 06:41:58 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Thu Apr 21 06:44:58 2016-date Thu Apr 21 06:41:58 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Thu Apr 21 06:46:32 2016-date Thu Apr 21 06:44:02 2016 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 21 06:46:32 2016-date Thu Apr 21 06:44:02 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Thu Apr 21 06:46:32 2016-date Thu Apr 21 06:44:02 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Thu Apr 21 06:48:43 2016-date Thu Apr 21 06:45:48 2016 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 21 06:48:43 2016-date Thu Apr 21 06:45:48 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Thu Apr 21 06:48:43 2016-date Thu Apr 21 06:45:48 2016 s - exit: 21504

wmtan · 2016-04-21T05:06:06Z

Closed temporarily while I investigate the test errors.

cmsbuild · 2016-04-21T05:29:13Z

-1

Tested at: bde3aa4

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14169/12533/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
9.0 step1

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Thu Apr 21 07:14:12 2016-date Thu Apr 21 07:10:43 2016 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 21 07:14:12 2016-date Thu Apr 21 07:10:43 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Thu Apr 21 07:14:12 2016-date Thu Apr 21 07:10:43 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Thu Apr 21 07:14:00 2016-date Thu Apr 21 07:10:50 2016 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 21 07:14:00 2016-date Thu Apr 21 07:10:50 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Thu Apr 21 07:14:00 2016-date Thu Apr 21 07:10:50 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_8TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Thu Apr 21 07:16:19 2016-date Thu Apr 21 07:14:05 2016 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 21 07:16:19 2016-date Thu Apr 21 07:14:05 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Thu Apr 21 07:16:19 2016-date Thu Apr 21 07:14:05 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Thu Apr 21 07:17:05 2016-date Thu Apr 21 07:14:20 2016 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 21 07:17:05 2016-date Thu Apr 21 07:14:20 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Thu Apr 21 07:17:05 2016-date Thu Apr 21 07:14:20 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Thu Apr 21 07:18:45 2016-date Thu Apr 21 07:16:23 2016 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 21 07:18:45 2016-date Thu Apr 21 07:16:23 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Thu Apr 21 07:18:45 2016-date Thu Apr 21 07:16:23 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Thu Apr 21 07:20:37 2016-date Thu Apr 21 07:17:49 2016 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-04-20-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 21 07:20:37 2016-date Thu Apr 21 07:17:49 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Thu Apr 21 07:20:37 2016-date Thu Apr 21 07:17:49 2016 s - exit: 21504

cmsbuild · 2016-04-22T02:49:27Z

Pull request #14169 was updated. @cmsbuild, @covarell, @govoni, @thuer, @davidlange6 can you please check and sign again.

wmtan · 2016-04-22T02:50:41Z

The problem causing the test failures was found and fixed.

wmtan · 2016-04-22T02:50:57Z

@cmsbuild please test

cmsbuild · 2016-04-22T02:51:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12574/console

cmsbuild · 2016-04-22T06:02:23Z

+1
Tested at: 0fb96b8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14169/12574/summary.html

cmsbuild · 2016-04-22T07:10:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14169/12574/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2

davidlange6 · 2016-04-28T12:15:37Z

@wmtan @Dr15Jones this PR most likely broke all of the gen workflows -could you have a look?

eg

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc493/CMSSW_8_1_X_2016-04-27-2300/pyRelValMatrixLogs/run/521.0_WTolNuJets_LO_Mad_13TeV_py8_Ta+WTolNu01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCUETP8M1_13TeV_MLM_5f_max4j_LHE_pythia8_Tauola+HARVESTGEN2/step2_WTolNuJets_LO_Mad_13TeV_py8_Ta+WTolNu01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCUETP8M1_13TeV_MLM_5f_max4j_LHE_pythia8_Tauola+HARVESTGEN2.log

wmtan · 2016-04-28T15:07:30Z

David, (and Chris),

As testing of my first attempt at this PR revealed a similar error,
which I fixed, you are almost certainly correct that this PR broke this.
The fix should be easy, but since I have other plans this morning and
early afternoon, (ah! retirement, or to be precise, vacation run out),
I may not get to it until about 3PM this afternoon (Fermi time).
Worst case, tomorrow (Friday) I have no other commitments, so it should
certainly be fixed then.
The same error may occur in several places. I will look at all the
relval matrix and other tests, and make sure all are fixed, but if there
are any failing workflows that are not in the relvals or other tests, I
would need to know what they are.

Bill

On 4/28/16 7:15 AM, David Lange wrote:

@wmtan https://github.com/wmtan @Dr15Jones
https://github.com/Dr15Jones this PR most likely broke all of the
gen workflows -could you have a look?

eg

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc493/CMSSW_8_1_X_2016-04-27-2300/pyRelValMatrixLogs/run/521.0_WTolNuJets_LO_Mad_13TeV_py8_Ta+WTolNu01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCUETP8M1_13TeV_MLM_5f_max4j_LHE_pythia8_Tauola+HARVESTGEN2/step2_WTolNuJets_LO_Mad_13TeV_py8_Ta+WTolNu01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCUETP8M1_13TeV_MLM_5f_max4j_LHE_pythia8_Tauola+HARVESTGEN2.log

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#14169 (comment)

Dr15Jones · 2016-04-28T15:13:27Z

@wmtan don't worry, I've been looking into it this morning.

Dr15Jones · 2016-04-28T15:19:31Z

The crash happens in this line

433   leadTrackpt->Fill(hepmcGPCollection[iMax]->momentum().perp(),weight);

where iMax == 0 and hepmcGPCollection is an empty vector.

wmtan · 2016-04-28T15:19:53Z

Chris,
The other error causing a similar segfault was due to changing a
std::auto_ptr to std::unique_ptr in a place that was not necessary, and
was a place where auto_ptr and unique_ptr did not behave the same way.
Rather that spending a lot of time investigating the different behavior,
I just changed it back to auto_ptr, which fixed the problem. It was not
involved in a put call.
No guarantee this error(s) is the same, but the symptoms are identical.

Bill

On 4/28/16 10:13 AM, Chris Jones wrote:

@wmtan https://github.com/wmtan don't worry, I've been looking into
it this morning.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#14169 (comment)

Dr15Jones · 2016-04-28T21:32:44Z

#14293 fixes at least some of the problem if not all

wmtan · 2016-04-28T23:14:03Z

@Dr15Jones You are correct that reset is the problem, and that unique_ptr.reset() does not have a check for the same pointer as the old one. However, I do not yet fully understand why unique_ptr::reset() gives an incorrect result in this case. I don't know if this is a general problem or a problem specific to certain classes, such as HepMC::GenEvent. The problem may (or may not) be that HepMC::GenEvent is not correctly movable. Indeed, HepMC::GenEvent was written in 1999, well before C++11, and has no support for moving. It is 3rd party code.
I will investigate these issues tomorrow, so I can figure out which resets can cause a problem.

cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 20, 2016

cmsbuild added generators-pending pending-signatures tests-pending orp-pending comparison-pending labels Apr 20, 2016

cmsbuild added tests-started and removed tests-pending labels Apr 20, 2016

cmsbuild added tests-rejected and removed tests-started labels Apr 20, 2016

wmtan force-pushed the UseUniquePtrInGenerators branch from fffefc6 to bde3aa4 Compare April 20, 2016 20:47

cmsbuild added core-pending tests-pending and removed tests-rejected labels Apr 20, 2016

cmsbuild added tests-started and removed tests-pending labels Apr 20, 2016

cmsbuild added tests-rejected and removed tests-started labels Apr 21, 2016

wmtan closed this Apr 21, 2016

Use unique_ptr, not auto_ptr

0fb96b8

wmtan reopened this Apr 22, 2016

wmtan force-pushed the UseUniquePtrInGenerators branch from bde3aa4 to 0fb96b8 Compare April 22, 2016 02:49

cmsbuild added tests-pending and removed core-pending tests-rejected labels Apr 22, 2016

cmsbuild added tests-started and removed tests-pending labels Apr 22, 2016

cmsbuild added tests-approved and removed tests-started labels Apr 22, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 22, 2016

slava77 mentioned this pull request Apr 22, 2016

update names of run2 workflows cms-sw/cms-bot#666

Merged

davidlange6 merged commit c490209 into cms-sw:CMSSW_8_1_X Apr 26, 2016

wmtan deleted the UseUniquePtrInGenerators branch May 26, 2016 04:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use unique_ptr, not auto_ptr, in Generators #14169

Use unique_ptr, not auto_ptr, in Generators #14169

wmtan commented Apr 20, 2016

cmsbuild commented Apr 20, 2016

wmtan commented Apr 20, 2016

cmsbuild commented Apr 20, 2016

cmsbuild commented Apr 20, 2016

cmsbuild commented Apr 20, 2016

cmsbuild commented Apr 20, 2016

wmtan commented Apr 20, 2016

cmsbuild commented Apr 20, 2016

cmsbuild commented Apr 21, 2016

wmtan commented Apr 21, 2016

cmsbuild commented Apr 21, 2016

cmsbuild commented Apr 22, 2016

wmtan commented Apr 22, 2016

wmtan commented Apr 22, 2016

cmsbuild commented Apr 22, 2016

cmsbuild commented Apr 22, 2016

cmsbuild commented Apr 22, 2016

davidlange6 commented Apr 28, 2016

wmtan commented Apr 28, 2016

Dr15Jones commented Apr 28, 2016

Dr15Jones commented Apr 28, 2016

wmtan commented Apr 28, 2016

Dr15Jones commented Apr 28, 2016

wmtan commented Apr 28, 2016

Use unique_ptr, not auto_ptr, in Generators #14169

Use unique_ptr, not auto_ptr, in Generators #14169

Conversation

wmtan commented Apr 20, 2016

cmsbuild commented Apr 20, 2016

wmtan commented Apr 20, 2016

cmsbuild commented Apr 20, 2016

cmsbuild commented Apr 20, 2016

cmsbuild commented Apr 20, 2016

cmsbuild commented Apr 20, 2016

wmtan commented Apr 20, 2016

cmsbuild commented Apr 20, 2016

cmsbuild commented Apr 21, 2016

wmtan commented Apr 21, 2016

cmsbuild commented Apr 21, 2016

cmsbuild commented Apr 22, 2016

wmtan commented Apr 22, 2016

wmtan commented Apr 22, 2016

cmsbuild commented Apr 22, 2016

cmsbuild commented Apr 22, 2016

cmsbuild commented Apr 22, 2016

davidlange6 commented Apr 28, 2016

wmtan commented Apr 28, 2016

Dr15Jones commented Apr 28, 2016

Dr15Jones commented Apr 28, 2016

wmtan commented Apr 28, 2016

Dr15Jones commented Apr 28, 2016

wmtan commented Apr 28, 2016