Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safety fix for L1TriggerConfig/DTTPGConfig: Const function returns pointer or reference to non-const object #1420

Merged
merged 2 commits into from Nov 15, 2013
Merged

Thread safety fix for L1TriggerConfig/DTTPGConfig: Const function returns pointer or reference to non-const object #1420

merged 2 commits into from Nov 15, 2013

Conversation

smuzaffar
Copy link
Contributor

Fixed: Const function returns pointer or reference to non-const object
const_cast used

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_7_0_X.

Thread safety fix for L1TriggerConfig/DTTPGConfig: Const function returns pointer or reference to non-const object

It involves the following packages:

L1Trigger/DTBti
L1Trigger/DTTraco
L1Trigger/DTTriggerServerPhi
L1TriggerConfig/DTTPGConfig
L1Trigger/DTTriggerServerTheta
L1Trigger/DTSectorCollector
DQM/DTMonitorClient

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor

Looks good to me.

@cmsbuild
Copy link
Contributor

@mulhearn
Copy link
Contributor

+1

1 similar comment
@deguio
Copy link
Contributor

deguio commented Nov 15, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 15, 2013
…nfig-DTTPGConfig

Multithreading fix -- L1TriggerConfig/DTTPGConfig: Const function returns pointer or reference to non-const object
@ktf ktf merged commit 5024615 into cms-sw:CMSSW_7_0_X Nov 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants