Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a few statics const in CondFormats/JetMETObjects #1425

Merged
merged 1 commit into from Nov 25, 2013
Merged

Make a few statics const in CondFormats/JetMETObjects #1425

merged 1 commit into from Nov 25, 2013

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Nov 12, 2013

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X.

Make a few statics const in CondFormats/JetMETObjects

It involves the following packages:

CondFormats/JetMETObjects

@ggovi, @vadler, @apfeiffer1, @nclopezo, @cmsbuild can you please review it and eventually sign? Thanks.
@TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

Dr15Jones
Dr15Jones reviewed Nov 12, 2013
View reviewed changes
CondFormats/JetMETObjects/src/JetCorrectorParameters.cc
@@ -326,91 +326,90 @@ void JetCorrectorParameters::printFile(const std::string& fFileName) const
txtFile.close();
}

const std::vector<std::string> labels_ = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These would be added to the global symbol table. I suggest either declaring these static or put in an anonymous namespace.

@apfeiffer1
Copy link
Contributor

+1 -- provided Chris' suggestion is taken ... :) Giulio, are you planning to update this PR ?

@vadler
Copy link

vadler commented Nov 18, 2013

@ktf : I'm also just waiting for a reply on that....

@apfeiffer1
Copy link
Contributor

... ping ...

@cmsbuild
Copy link
Contributor

Pull request #1425 was updated. @ggovi, @vadler, @apfeiffer1, @nclopezo, @cmsbuild can you please check and sign again.

@vadler
Copy link

vadler commented Nov 25, 2013

+1

@ktf
Copy link
Contributor Author

ktf commented Nov 25, 2013

Assuming @apfeiffer1 is still ok with it.

ktf added a commit that referenced this pull request Nov 25, 2013
@ktf
Merge pull request #1425 from ktf/sr-CondFormats-JetMETObjects
583e3b5 
Multithreading fixes -- Make a few statics const in CondFormats/JetMETObjects
@ktf ktf merged commit 583e3b5 into cms-sw:CMSSW_7_0_X Nov 25, 2013
@ktf ktf deleted the sr-CondFormats-JetMETObjects branch November 25, 2013 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved db-pending pending-signatures tests-pending
Projects
None yet
Milestone
CMSSW_7_0_0_pre9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ktf @cmsbuild @apfeiffer1 @vadler @Dr15Jones