bug fix in the APV Killing procedure

[sdevissc]

This fix is required, assuming the definition of localLastChannel (from see

cmssw/SimTracker/SiStripDigitizer/plugins/SiTrivialInduceChargeOnStrips.cc

Line 249 in 0397259

auto affectedUntilStrip = std::min(Nstrips, strip + sc);

).

Example: if there are 512 strips (4 APVs), and if it turns out that localLastChannel = 512, then without the fix, LastAPV = 4 instead of 3 (as 0->127 the APV count is 0, 128->255 is 1, 256->383 is 2, 384->511 is 3).

[cmsbuild]

A new Pull Request was created by @sdevissc for CMSSW_8_1_X.

It involves the following packages:

SimTracker/SiStripDigitizer

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @jlagram, @rovere, @VinInn, @cnuttens, @prolay, @cerati, @threus, @dgulhan, @LBeck this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12646/console

[cmsbuild]

+1
Tested at: d07d29d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14255/12646/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14255/12646/summary.html

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar