Consumes migration for triggerResultsByName

[wddgit]

Note that SUSYBSMAnalysis/HSCP/plugins/HSCPValidator.cc shows many lines changed only because the previous version had DOS line endings. Ignoring that, the changes in that file are almost the same as in SUSYBSMAnalysis/HSCP/plugins/HSCPHLTFilter.cc.

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/FWLite
FWCore/Common
FWCore/Framework
PhysicsTools/FWLite
SUSYBSMAnalysis/HSCP

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12655/console

[Dr15Jones]

Since this is Core code, how about changing to getByToken?

[wddgit]

This a module used only for tests. It has both a call to getManyByType and also getByLabel, both getting the TriggerResults type. There is a consumesMany call that allows both of those to work. I am not sure what happens if you call both consumes to get a token and also consumesMany for the same type.

[Dr15Jones]

+1

[cmsbuild]

-1

Tested at: 140e01a

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
25fce4e
e44a862
a11f326
5fb9f4b
b3db0a9
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14262/12655/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14262/12655/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14262/12655/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
25fce4e
e44a862
a11f326
5fb9f4b
b3db0a9
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14262/12655/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14262/12655/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14262/12655/summary.html

[davidlange6]

@smuzaffar - it seems that the error harvesting didn't work above...

[Dr15Jones]

@smuzaffar Looking at the unit test log I found

===== Test "TestSiStripDCS" ====
TestSiStripDCS::testEquality. : OK
TestSiStripDCS::testAddition. : OK
TestSiStripDetVOffBuilder::testConstructor. : errorE
TestSiStripDetVOffBuilder::testReduction. : errorE



!!!FAILURES!!!
Test Results:
Run:  4   Failures: 0   Errors: 2


1) test: TestSiStripDetVOffBuilder::testConstructor (E) 
setUp() failed
- uncaught exception of type N3edm9ExceptionE
- An exception of category 'Configuration' occurred.
Exception Message:
MissingParameter: Parameter 'DeltaTmin' not found.



2) test: TestSiStripDetVOffBuilder::testReduction (E) 
setUp() failed
- uncaught exception of type N3edm9ExceptionE
- An exception of category 'Configuration' occurred.
Exception Message:
MissingParameter: Parameter 'DeltaTmin' not found.




---> test TestSiStripDCS succeeded

Very strange that cppunit said there was an error but the test framework thought there was not.

[Dr15Jones]

I think I found the reason scram thinks everything is OK. The test writer didn't use the standard way of running the tests:
http://cmslxr.fnal.gov/source/CalibTracker/SiStripDCS/test/UnitTests/MasterTestSiStripDCS.cpp?v=CMSSW_8_1_X_2016-04-25-2300

that specially made main always returns 0 so scram never gets to know there was a problem.

[Dr15Jones]

#14270

[smuzaffar]

@davidlange6 , it could be that unit tests took more than 7200s to finish.
@Dr15Jones, scram only uses the exit code of the tests. For this test TestSiStripDCS it is returning 0.