Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync with 80X and cleanup of obsolete T0 processing scenarios #14350

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented May 3, 2016

  • 80X changes to DataProcessing configs are updated to what's been actively used in 80X already
  • pre-era scenarios are removed: ppRun2 (use ppEra_Run2_2016), ppRun2at50ns (use ppEra_Run2_50ns), ppRun2B0T (use ppEra_Run2_trackingLowPU), cosmicsRun2 (use cosmicsEra_Run2_2016), HeavyIonsRun2 (use HeavyIonsEra_Run2_HI), hcalnzsRun2 (use hcalnzsEra_Run2_2016)
  • customisations in RecoTLR corresponding to the pre-era scenarios (customiseDeprecated methods) are removed. The customisation functions are left to be removed later.

Most of the changes here were assumed for auto-forward-port of #13945 but were locked out due to conflicts in other areas.
This PR is needed to get #14267 going. @makortel

Configuration/DataProcessing/python/Modifiers.py and RecoVertex/BeamSpotProducer/python/Modifiers.py are not fully used at this point. More extensive use is pending Eras.py refactoring.

@slava77
Copy link
Contributor Author

slava77 commented May 3, 2016

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone May 3, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2016

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2016

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_1_X.

It involves the following packages:

Configuration/DataProcessing
DQM/Integration
RecoVertex/BeamSpotProducer

@ghellwig, @cvuosalo, @cerminar, @dmitrijus, @cmsbuild, @franzoni, @deguio, @slava77, @mmusich, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @batinkov, @makortel, @GiacomoSguazzoni, @tocheng, @VinInn, @Martin-Grunewald, @rovere, @cerati, @threus, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@rovere
Copy link
Contributor

rovere commented May 3, 2016

@slava77 I assume I can "port" the beamspot+PV fix for the lowPU era on top of this PR, right?

@slava77
Copy link
Contributor Author

slava77 commented May 3, 2016

@rovere
there is no strict connection to this PR in the beamspot+PV fix.
That fix needs trackingLowPU era to be present, which is available since #13988 was merged (11 days ago, but missed 801pre3)

@rovere
Copy link
Contributor

rovere commented May 3, 2016

@slava77 not really, since #13988 does not update Configuration/DataProcessing....

@slava77
Copy link
Contributor Author

slava77 commented May 3, 2016

right, but changes in #14150 (which, I suppose are the target for the forward port)
only need the trackingLowPU era from #13988 , the tests can be done with cmsDriver.

Anyways, the port of #14150 could wait for this PR to be integrated, if it's more convenient to you.

@slava77
Copy link
Contributor Author

slava77 commented May 3, 2016

@slava77
Copy link
Contributor Author

slava77 commented May 3, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12801/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2016

@slava77
Copy link
Contributor Author

slava77 commented May 4, 2016

+1

for #14350 112ef0c

  • jenkins tests pass (including package unit tests) and comparisons with baseline show no relevant differences

@deguio
Copy link
Contributor

deguio commented May 4, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants