Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tracking MC validation scripts #14372

Merged
merged 16 commits into from May 13, 2016
Merged

Update tracking MC validation scripts #14372

merged 16 commits into from May 13, 2016

Conversation

makortel
Copy link
Contributor

@makortel makortel commented May 4, 2016

This PR updates the tracking MC validation scripts. Notable updates

  • New plots
    • Efficiency and fake rate vs. pileup
    • Fake rate etc. vs. seeding layer set (histograms added in just-merged Add plots vs. seeding layer set to MultiTrackValidator #14248)
    • Produce vertex validation plots also for FastSim (now that vertex validation is included there)
    • Time per built track and per selected high-purity track for each iteration
  • Add a set of "extended" plots that are not produced by default, but e.g. with makeTrackValidationPlots.py --extended
    • For now these include the distributions of all/true/fake/duplicate tracks vs. the same quantities as the fake/duplicate/pileup rate plots are made

Tested in 8_1_0_pre3, no changes expected in standard workflows.

@rovere @VinInn

makortel added 16 commits May 4, 2016 14:02
@makortel
Add efficiency and fake rate vs pu
db609f1
@makortel
Update campaigns
d5fcfee
@makortel
Continue instead of aborting if FullSim sample is missing from FastSi…
691fea7 
…m-FullSim comparison
@makortel
Reorder iterations to reflect better the reality
ce5ee4b
@makortel
Add set of extended plots that are not produced by default (RelVals),…
7702113 
… but can be easily produced when needed
@makortel
Tune plots
22bc344
@makortel
Add more fallbacks for associator/association name changes
ab0e290
@makortel
Produce electron and conversion plots only for selected samples
51c2b67
@makortel
Improve plot customizations from plot scripts
c8e113b 
- add optional outname (allows better renaming of plots for output)
- allow cloning of plots (allows better creating several new versions of an existing plot)
- allow PlotGroup properties to be set afterwards
- allow PlotGroup to be cleared
@makortel
Suppress warning about calling Sumw2() again
c723c68
@makortel
Add time per built/selected track
149e508
@makortel
Add options to remove empty bins and to print bin values
ae29fd7
@makortel
Add plots vs. seeding layer set
4c6227d
@makortel
Add check for duplicate file names
8a851ff
@makortel
Add flag to disable legend per PlotGroup
90b598a
@makortel
Produce vertex validation plots also for FastSim
8eaa8b0
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone May 4, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

Validation/RecoTrack
Validation/RecoVertex

@cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @wmtford, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@makortel
Copy link
Contributor Author

ping

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12949/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 8eaa8b0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14372/12949/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14372/12949/summary.html

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b95a736 into cms-sw:CMSSW_8_1_X May 13, 2016
@makortel makortel deleted the trackingValidation_v8 branch April 19, 2017 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makortel @cmsbuild @dmitrijus @davidlange6