Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1CSC Trigger Primitive conditions DB vs Python config comparator #14382

Merged
merged 1 commit into from May 26, 2016
Merged

L1CSC Trigger Primitive conditions DB vs Python config comparator #14382

merged 1 commit into from May 26, 2016

Conversation

dildick
Copy link
Contributor

@dildick dildick commented May 5, 2016

This module enables one to compare the settings in Python with conditions DB for the L1 CSC trigger primitive emulator without producing cmsDriver configs. It is rather handy when debugging data vs emulator comparisons. This is only a tester. It does not affect the workflows in any era. It prints out a report like the one below:

cmsRun runL1CSCTPEmulatorConfigAnalyzer_cfg.py type=Data
# Conditions read from  CMS_CONDITIONS  via FrontierProd 
---------------------------------------------------------------------------
Release: CMSSW_8_1_0_pre4 , globaltag: 80X_dataRun2_v14
---------------------------------------------------------------------------
Begin processing the 1st record. Run 1, Event 1, LumiSection 1 at 05-May-2016 01:55:58.655 CEST

Start Comparing the L1 CSC TP emulator settings between Python and conditions DB.

Parameters different between Py and DB
- - - - - - - - - - - - - - - - - - - 

alctNplanesHitPretrig: Py = 3, DB = 2
alctNplanesHitAccelPretrig: Py = 3, DB = 2

clctHitPersist: Py = 4, DB = 6
clctNplanesHitPretrig: Py = 3, DB = 2
clctPidThreshPretrig: Py = 4, DB = 2
clctMinSeparation: Py = 5, DB = 10

tmbMpcBlockMe1a: Py = 0, DB = 1
tmbMatchTrigWindowSize: Py = 3, DB = 7

Parameters same in Py and DB
- - - - - - - - - - - - - - 

alctFifoTbins: 16
alctFifoPretrig: 10
alctDriftDelay: 2
alctNplanesHitPattern: 4
alctNplanesHitAccelPattern: 4
alctTrigMode: 2
alctAccelMode: 0
alctL1aWindowWidth: 7

clctFifoTbins: 12
clctFifoPretrig: 7
clctDriftDelay: 2
clctNplanesHitPattern: 4

tmbAlctTrigEnable: 0
tmbClctTrigEnable: 0
tmbMatchTrigEnable: 1
tmbL1aWindowSize: 7

Done.

@ptcox: This will help to clean up the mess regarding Run1 vs Run2, DB vs Py, MC vs Data

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2016

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13195/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@dildick
Copy link
Contributor Author

dildick commented May 25, 2016

As expected, I don't see any significant changes in the DQM plots.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6823c4d into cms-sw:CMSSW_8_1_X May 26, 2016
@dildick dildick deleted the from-CMSSW_8_1_0_pre4-tp-settings-comparator branch May 26, 2016 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants