Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing Phase2 RPC local reco #14386

Merged
merged 1 commit into from May 11, 2016
Merged

Conversation

bapavlov
Copy link
Contributor

@bapavlov bapavlov commented May 5, 2016

Fixing rpcRecHit for Phase2 Era.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2016

A new Pull Request was created by @bapavlov for CMSSW_8_1_X.

It involves the following packages:

RecoLocalMuon/RPCRecHit

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented May 5, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12841/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2016

@slava77
Copy link
Contributor

slava77 commented May 11, 2016

+1

for #14386 75712bc

  • code change is OK: use sim RPC digis in phase2 instead of unpacked digis because upgrade detectors are not packed (yet?)
  • jenkins tests pass; there are no changes (phase2 wf is not tested)
  • local test using 11024 shows that rpcRecHits are now filled (the plot below has ref and new inverted)
    all_origvstest14386_ttbar13tev2023wf11024p0c_rpcdetidrpcrechitsownedrangemap_rpcrechits__reco_obj_collection__data__clustersize

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 08a43c3 into cms-sw:CMSSW_8_1_X May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants