Added noexcept(false) to module destructors for gcc 6

[Dr15Jones]

For now, we will continue to allow module's destructors to throw exceptions. Explicitly added 'noexcept(false)' to base class destructors to silence warnings from gcc 6.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X.

It involves the following packages:

FWCore/Framework
FWCore/Integration
FWCore/Sources

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12852/console

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

-1

Tested at: 83f2802

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14396/12852/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-06-1100/src/Validation/EventGenerator/src/DQMHelper.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-06-1100/src/Validation/EventGenerator/src/TauDecay.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-06-1100/src/Validation/EventGenerator/src/TauDecay_CMSSW.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-06-1100/src/Validation/EventGenerator/src/CaloCellId.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-06-1100/src/Validation/RecoParticleFlow/plugins/GenericBenchmarkAnalyzer.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-06-1100/src/Validation/RecoParticleFlow/plugins/GenericBenchmarkAnalyzer.h:21:11: error: looser throw specifier for 'virtual GenericBenchmarkAnalyzer::~GenericBenchmarkAnalyzer() noexcept (false)'
   virtual ~GenericBenchmarkAnalyzer();
           ^
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-06-1100/src/Validation/RecoParticleFlow/plugins/GenericBenchmarkAnalyzer.h:11:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-06-1100/src/Validation/RecoParticleFlow/plugins/GenericBenchmarkAnalyzer.cc:1:
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-05-06-1100/src/RecoParticleFlow/Benchmark/interface/GenericBenchmark.h:29:11: error:   overriding 'virtual GenericBenchmark::~GenericBenchmark() noexcept'


[cmsbuild]

Pull request #14396 was updated. @smuzaffar, @Dr15Jones, @cvuosalo, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12856/console

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[Dr15Jones]

The test failure appears to be a transient problem. From the logs it says

===== Test "TestFWCoreIntegrationStandalone" ====
Running .

Traceback helper thread failed to read from parent: Bad file descriptor
/bin/sh: line 1: 26777 Aborted                 TestFWCoreIntegrationStandalone

---> test TestFWCoreIntegrationStandalone had ERRORS

When I run the tests in my local area they pass fine.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12904/console

[ghellwig]

+1

[cmsbuild]

+1
Tested at: 1e89dbc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14396/12904/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14396/12904/summary.html

[slava77]

+1

for #14396 1e89dbc

• changes are as described
• jenkins tests pass

[davidlange6]

+1