Electron validation 81X preshower

[archiron]

The quantity superCluster()->preshowerEnergy() / superCluster()->rawEnergy() is used in the electron ID and tracking changes would be useful.

This new histo was added for validation in the case of endcaps only.
The files used for this implementation are :
Validation/RecoEgamma/plugins/ElectronMcFakeValidator.cc (h)
Validation/RecoEgamma/plugins/ElectronMcSignalValidator.cc (h)

The files 👍 Validation/RecoEgamma/test/ElectronMcSignalHistos.txt and Validation/RecoEgamma/test/ElectronMcFakeHistos.txt are used for web page creation and include the new histo.

Others minors correction :
Validation/RecoEgamma/test/ElectronMcFakePostValidation_cfg.py
Validation/RecoEgamma/test/ElectronMcFakeValidation_gedGsfElectrons_cfg.py
in which a small Global Tag use is corrected

Validation/RecoEgamma/test/electronCompare.C
for these file, there is a small correction in web page creation due to gcc530.

@beaudett @matteosan1 @fcouderc @pigard

[cmsbuild]

A new Pull Request was created by @archiron (Chiron) for CMSSW_8_1_X.

It involves the following packages:

Validation/RecoEgamma

@cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@richard-cms this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[dmitrijus]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12868/console

[dmitrijus]

+1
Code looks okay

One comment:
It's okay and advisable to split your work into multiple commits. But this is too ridiculous...
A commit should mean a single piece of work, spanning multiple files (not per file).
In other words - if I check out a commit - it should represent a consistent state of code,
at a certain point in history.
Please, for the future, either use git commit --amend or squash/rebase ( https://www.atlassian.com/git/tutorials/rewriting-history/ )

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[archiron]

OK.
In fact I tried to follow the davidlt comment in #12895, but perhaps there is something I misunderstand.
So I have to give one commit explaining the work, and eventually give a more detailed (per file) into the PR abstract.
Please, sorry for this wrong way to work.

[cmsbuild]

+1
Tested at: 9f1d488
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14412/12868/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14412/12868/summary.html

[davidlange6]

+1