Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HLT-L1T seed index to be from begin BxVector #14414

Merged

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented May 9, 2016

ObjectMap of L1T objects is providing indices relative to Bx = 0.
This is a fix to use object indexing relative to begin of BxVector when making TriggerObjectRefs in the HLT-L1T interface module.

The fix should solve the problem of low rates of EG HLT paths observed in last night's data taking.
Please merge and make a patch for immediate data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

A new Pull Request was created by @rekovic for CMSSW_8_0_X.

It involves the following packages:

HLTrigger/HLTfilters

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@rekovic
Copy link
Contributor Author

rekovic commented May 9, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12870/console

@Martin-Grunewald
Copy link
Contributor

please test

@fwyzard
Copy link
Contributor

fwyzard commented May 9, 2016

hi @rekovic , shouldn't the references for the energy sums be fixed in a similar way ?

@rekovic
Copy link
Contributor Author

rekovic commented May 9, 2016

@fwyzard Refs to energy sums do not need fixes as they were already taken from Bx = 0.

@davidlange6 davidlange6 merged commit ac15510 into cms-sw:CMSSW_8_0_X May 9, 2016
@davidlange6
Copy link
Contributor

I'll start a build in parallel with these tests...

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants