Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for RunInfo O2O and cleanup of PopCon interface #14420

Merged
merged 10 commits into from May 18, 2016

Conversation

diguida
Copy link
Contributor

@diguida diguida commented May 9, 2016

The RunInfo O2O has been modified:

  • Make the tag population in synch with the CondDBv2 tag policy. In https://github.com/diguida/cmssw/blob/fix_RunInfo_and_PopCon/CondCore/CondDB/src/IOVEditor.cc#L189-L201, as specified in the comment too, if the tag has synchronisation ANY or VALIDATION, IOV insertion in the past or overriding are allowed, while they are forbidden (an exception is thrown) for "production" tags. The RunInfo code is now protected so that it first tests the input run number against the last IOV of the target tag: if the new run number is smaller than or equal to the latest IOV in the target tag, the job exits, and no new IOVs are added irrespectively of the synchronisation;
  • Use CondCore API as defined in ConnectionPool in order to authenticate Oracle access via roles, instead of the CORAL API in RelationalAccess;
  • Improve queries by performing joins on PK-FK (query time improved by factor 2);
  • Throw exceptions in case CORAL fails to execute a query;
  • Improve logging messages;
  • Improve code style;
  • Review the configuration file to be fully complaint with the O2O online framework.

Removed a dead data member in PopCon.

Added a comment in CondCore/CondDB/src/IOVEditor.cc clarifying the tag update policy w.r.t. tag synchronisation.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_8_1_X.

It involves the following packages:

CondCore/CondDB
CondCore/PopCon
CondTools/RunInfo

@ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented May 9, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12876/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

Pull request #14420 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

Pull request #14420 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

@diguida
Copy link
Contributor Author

diguida commented May 9, 2016

Few changes to make code comments more clear

@mmusich
Copy link
Contributor

mmusich commented May 9, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

@ggovi
Copy link
Contributor

ggovi commented May 12, 2016

+1

@mmusich
Copy link
Contributor

mmusich commented May 17, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a54978b into cms-sw:CMSSW_8_1_X May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants