New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for RunInfo O2O and cleanup of PopCon interface #14420
Conversation
A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_8_1_X. It involves the following packages: CondCore/CondDB @ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
… is smaller than or equal to the latest IOV, exit.
… for production and offline for testing via VarParsing support.
…ect CORAL RelationalAccess API; use joins in queries; throw in case a query goes wrong; improve code style.
f4d26f4
to
1efb6b3
Compare
1efb6b3
to
44497ff
Compare
Few changes to make code comments more clear |
please test |
The tests are being triggered in jenkins. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
The RunInfo O2O has been modified:
CondDBv2
tag policy. In https://github.com/diguida/cmssw/blob/fix_RunInfo_and_PopCon/CondCore/CondDB/src/IOVEditor.cc#L189-L201, as specified in the comment too, if the tag has synchronisationANY
orVALIDATION
, IOV insertion in the past or overriding are allowed, while they are forbidden (an exception is thrown) for "production" tags. The RunInfo code is now protected so that it first tests the input run number against the last IOV of the target tag: if the new run number is smaller than or equal to the latest IOV in the target tag, the job exits, and no new IOVs are added irrespectively of the synchronisation;CondCore
API as defined inConnectionPool
in order to authenticateOracle
access via roles, instead of theCORAL
API inRelationalAccess
;Removed a dead data member in PopCon.
Added a comment in
CondCore/CondDB/src/IOVEditor.cc
clarifying the tag update policy w.r.t. tag synchronisation.