Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up clang warnings #14428

Merged
merged 1 commit into from May 10, 2016
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented May 10, 2016

  • Remove warnings of hidden overloaded virtual function
  • Remove warnings of overridden virtual function

* Remove warnings of overridden virtual function
@ianna
Copy link
Contributor Author

ianna commented May 10, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12892/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_1_X.

It involves the following packages:

Geometry/CommonTopologies
Geometry/EcalAlgo
Geometry/ForwardGeometry
Geometry/HGCalGeometry
Geometry/TrackerGeometryBuilder

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @ghellwig, @argiro, @VinInn, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor Author

ianna commented May 10, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 454bb71 into cms-sw:CMSSW_8_1_X May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants