fix det search tollerances for Cosmics

[VinInn]

title says all.
CRITICAL FIX.
we are loosing 50% of comics for alignment because of this oversight

[VinInn]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12933/console

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_8_0_X.

It involves the following packages:

RecoTracker/CkfPattern

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[cmsbuild]

+1
Tested at: 0c85e7e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14467/12933/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14467/12933/summary.html

[slava77]

@VinInn
Is there a good example run to see that this fixes the reco as desired?

I tried 272932 (this is from May 10, with B=3.8 T) and didn't see as significant effect as you suggest (50%) on 10K events:

• CosmicTP yield changed from 1037 to 1040 events
• CosmicSP yield changed from 59 to 57 events

I see in the inclusive sample about 25% increase in regionalCosmicTracks

The same from SP output:

And in TP:

The sizeable increase is only in 2-track event yields; the 1-track events haven't increased that much.

Is this roughly the expected improvement?

[VinInn]

expected (not sure for regionalCosmicTracks, I would call it a "side effect")

here for 0T
http://mrovere-dqmgui-slc6.cern.ch:8060/dqm/dev/start?runnr=256259;dataset=/Cosmici/CMSSW_8_0_7/RECO;sampletype=offline_data;filter=all;referencepos=ratiooverlay;referenceshow=all;referenceobj1=other%3A256259%3A/Cosmici/CMSSW_7_6_7/RECO%3A;referenceobj2=other%3A%3A/Cosmici/CMSSW_8_0_X/RECO%3A;referenceobj3=other%3A%3A/Cosmici/CMSSW_8_1_X/RECO%3A;referenceobj4=none;search=;striptype=object;stripruns=;stripaxis=run;stripomit=none;workspace=Everything;size=M;root=Tracking/TrackParameters/GeneralProperties;focus=Tracking/TrackParameters/GeneralProperties/NumberOfValidRecHitsPerTrackVsPhi_CosmicTk;zoom=no;

[slava77]

Here are a few more plots from a 0T run Cosmics PD in 269805.
Inclusive first

Here is from what passes SP skim

Muons have a much better increase

[slava77]

+1

for #14467 0c85e7e

• configuration change is in line with the needed fix
• jenkins tests pass and comparisons with baseline show small differences in the cosmics processing workflow 4.22 and also in cosmics-related variables (only in 10021, probably just a rare value to change)
• local tests in CRAFT and CRUZET data confirm expected improvements to a reasonable extent

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[VinInn]

@boudoul @mmusich
once integrated we may ask CRUZET rerun

[boudoul]

@VinInn : I agree, point taken, I will follow up once integrated

[mmusich]

@VinInn thanks a lot.
Two naive questions:

• why do we see that in CRUZET only?
• why haven't we seen it already last year?

Thanks,
Marco

[VinInn]

why do we see that in CRUZET only?
because in CRAFT seeds are triplets and therefore better defined
(apparently at 0T cosmics are seeded with doublets that are very badly defined)
why haven't we seen it already last year?
because the affected code is new

[davidlange6]

+1