Fix 2016 FG bit as MB trigger

[icali]

This update modify the FG calculation to accomodate the 2016 uHTR FW. The FG bits in 2016 are used to deliver minimum bias trigger. Should the PR be made also for 8_1_X?

[cmsbuild]

A new Pull Request was created by @icali (Ivan Amos Cali) for CMSSW_8_0_X.

It involves the following packages:

SimCalorimetry/HcalTrigPrimAlgos
SimCalorimetry/HcalTrigPrimProducers

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[nsmith-]

Will this also fill HcalTriggerPrimitiveDigi::SOI_fineGrain(1) for the HF TPs?
Also, is the unpacker change in the works?

[matz-e]

It'll fill that for the re-emulation. I haven't seen the FG bit set that way looking at data so far.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13121/console

[cmsbuild]

+1
Tested at: 2bc8476
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14471/13121/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14471/13121/summary.html

[icali]

hello, I see that this pull request is still pending signatures. What is missing? what should I do to have it in the release asap?

[fwyzard]

I'd say that @mulhearn or @rekovic should sign it, and request its inclusion at the next ORP meeting - though it will likely be necessary to have #14534 integrated in 8.1.x first.

[mulhearn]

Sorry, missed this. We just need to run our integration tests on this before signing...

[rekovic]

+1

Tests show this PR has no effect on the existing L1T functionality.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[rekovic]

For completion:
Tests of differences between L1T in vanilla CMSSW_8_0_14 and CMSSW_8_0_14+8_0_14+PR14471 reported here
http://rekovic.web.cern.ch/rekovic/cms/L1T/Stage2/l1t-integration/compare_test_CMSSW_8_0_14+PR14471-FG_MinBias_vs_test_CMSSW_8_0_14/
(i.e. There are no differences)

[davidlange6]

+1