Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1TGlobalProducer: migrate to stream module (81x) #14476

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 12, 2016

re-submission of #14352 after fixing a non-threadsafe construct

@fwyzard
Copy link
Contributor Author

fwyzard commented May 12, 2016

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented May 12, 2016

@rekovic @mulhearn could you have a look ?

@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12950/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

@rekovic
Copy link
Contributor

rekovic commented May 12, 2016

L1T unit tests passed

+1

@rekovic
Copy link
Contributor

rekovic commented May 12, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6 davidlange6 merged commit 1930024 into cms-sw:CMSSW_8_1_X May 13, 2016
@fwyzard fwyzard deleted the L1TGlobalProducer_migrate_to_stream_module_81x branch May 19, 2016 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants