Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused pixel CPE code #14490

Merged
merged 1 commit into from May 13, 2016
Merged

Conversation

ahinzmann
Copy link
Contributor

Remove unused code from pixel CPE.
No changes to RECO/AOD/MiniAOD.
Tested with:
runTheMatrix.py -l limited

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for CMSSW_8_1_X.

It involves the following packages:

RecoLocalTracker/SiPixelRecHits

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @gpetruc, @threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented May 13, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12963/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 166eeb9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14490/12963/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
134.911 step1

DAS Error

@slava77
Copy link
Contributor

slava77 commented May 13, 2016

@cmsbuild please test
maybe the DAS error goes away

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12967/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 13, 2016

+1

for #14490 166eeb9

  • code changes look OK: removal of the old CPE hidden behind compiler ifdef
  • jenkins tests pass and comparisons with baseline show no differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b15a4a4 into cms-sw:CMSSW_8_1_X May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants