Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Erf and Landau functions to FormulaEvaluator #14494

Merged

Conversation

Dr15Jones
Copy link
Contributor

Added Erf and Landau functions which are needed for jet energy corrections.

Added Erf and Landau functions which are needed for jet energy corrections.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X.

It involves the following packages:

CommonTools/Utils

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12979/console

@Dr15Jones
Copy link
Contributor Author

This was requested from #14430

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 15, 2016

@cmsbuild please test
to get a clean incremental test (without extraneous PRs merged during testing)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12995/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 16, 2016

+1

for #14494 5c796ab

  • code change is in line with the description; new feature is added
  • jenkins tests pass: unit test including testFormulaEvaluator.cc (testCommonToolsUtil) runs OK; comparisons with baseline show no differences

@Dr15Jones I suppose we will need a version in 80X as well.

@Dr15Jones
Copy link
Contributor Author

As usual, an 8_0_X version would happen after this one proves to not cause a problem in the IB.

@Dr15Jones
Copy link
Contributor Author

@slava77 #14522

@davidlange6 davidlange6 merged commit 32f0137 into cms-sw:CMSSW_8_1_X May 18, 2016
@Dr15Jones Dr15Jones deleted the addMoreFunctionsToFormulaEvaluator branch May 23, 2016 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants